Linux Overlay Filesystem development
 help / color / mirror / Atom feed
From: "Georg Müller" <georgmueller@gmx.net>
To: Miklos Szeredi <miklos@szeredi.hu>, Amir Goldstein <amir73il@gmail.com>
Cc: overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: overlayfs: supporting O_TMPFILE
Date: Fri, 29 Oct 2021 17:16:45 +0200	[thread overview]
Message-ID: <24940d86-e279-8586-7be7-52dab9215ead@gmx.net> (raw)
In-Reply-To: <YXvvAMJxj/DlyUqC@miu.piliscsaba.redhat.com>


Am 29.10.21 um 14:54 schrieb Miklos Szeredi:
> Here's something I prepared earlier;)
>
> Don't know why it got stuck, quite possibly I realized some fatal flaw that I
> can't remember anymore...
>
> Seems to work though, so getting this out for review and testing.

The code looks good to me.

I have a small test program which writes 100MB to a tmpfile and then checks its contents:

     https://github.com/georgmu/overlaytest

I have tested manual overlayfs creation (make overlaytest) and docker (make dockertest).

For docker: `docker info | grep "Storage Driver"` should be "overlay2".

I may enhance the test to create multiple tmpfiles in parallel.

Thank you very much for the code. I would add my tested-by.

Best regards,
Georg

  parent reply	other threads:[~2021-10-29 15:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28 20:41 overlayfs: supporting O_TMPFILE Georg Müller
2021-10-28 22:37 ` Amir Goldstein
2021-10-29 12:54   ` Miklos Szeredi
2021-10-29 13:47     ` Georg Müller
2021-10-29 15:16     ` Georg Müller [this message]
2022-04-19 14:01     ` Georg Müller
2022-04-20  8:21     ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24940d86-e279-8586-7be7-52dab9215ead@gmx.net \
    --to=georgmueller@gmx.net \
    --cc=amir73il@gmail.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox