From: Jeff Layton <jlayton@kernel.org>
To: Christoph Hellwig <hch@lst.de>, Christian Brauner <brauner@kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
David Sterba <dsterba@suse.com>, Jan Kara <jack@suse.cz>,
Mike Marshall <hubcap@omnibond.com>,
Martin Brandenburg <martin@omnibond.com>,
Carlos Maiolino <cem@kernel.org>, Stefan Roesch <shr@fb.com>,
linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, gfs2@lists.linux.dev,
io-uring@vger.kernel.org, devel@lists.orangefs.org,
linux-unionfs@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 09/16] fs: exit early in generic_update_time when there is no work
Date: Thu, 20 Nov 2025 08:32:33 -0500 [thread overview]
Message-ID: <3933f47761845a016dcb6c851a99fdcedffc65d0.camel@kernel.org> (raw)
In-Reply-To: <20251120064859.2911749-10-hch@lst.de>
On Thu, 2025-11-20 at 07:47 +0100, Christoph Hellwig wrote:
> Exit early if not attributes are to be updated, to avoid a spurious call
> to __mark_inode_dirty which can turn into a fairly expensive no-op due to
> the extra checks and locking.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/inode.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/inode.c b/fs/inode.c
> index 15a8b2cf78ef..cda78f76e1dd 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -2110,6 +2110,9 @@ int generic_update_time(struct inode *inode, int flags)
> int updated = inode_update_timestamps(inode, flags);
> int dirty_flags = 0;
>
> + if (!updated)
> + return 0;
> +
> if (updated & (S_ATIME|S_MTIME|S_CTIME))
> dirty_flags = inode->i_sb->s_flags & SB_LAZYTIME ? I_DIRTY_TIME : I_DIRTY_SYNC;
> if (updated & S_VERSION)
Reviewed-by: Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2025-11-20 13:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 6:47 re-enable IOCB_NOWAIT writes to files v2 Christoph Hellwig
2025-11-20 6:47 ` [PATCH 01/16] fs: refactor file timestamp update logic Christoph Hellwig
2025-11-20 6:47 ` [PATCH 02/16] fs: lift the FMODE_NOCMTIME check into file_update_time_flags Christoph Hellwig
2025-11-20 6:47 ` [PATCH 03/16] fs: export vfs_utimes Christoph Hellwig
2025-11-20 6:47 ` [PATCH 04/16] btrfs: use vfs_utimes to update file timestamps Christoph Hellwig
2025-11-20 6:47 ` [PATCH 05/16] btrfs: fix the comment on btrfs_update_time Christoph Hellwig
2025-11-20 6:47 ` [PATCH 06/16] orangefs: use inode_update_timestamps directly Christoph Hellwig
2025-11-20 6:47 ` [PATCH 07/16] fs: remove inode_update_time Christoph Hellwig
2025-11-20 6:47 ` [PATCH 08/16] fs: allow error returns from generic_update_time Christoph Hellwig
2025-11-20 6:47 ` [PATCH 09/16] fs: exit early in generic_update_time when there is no work Christoph Hellwig
2025-11-20 13:32 ` Jeff Layton [this message]
2025-11-20 6:47 ` [PATCH 10/16] fs: factor out a mark_inode_dirty_time helper Christoph Hellwig
2025-11-20 6:47 ` [PATCH 11/16] fs: allow error returns from inode_update_timestamps Christoph Hellwig
2025-11-20 14:01 ` Jeff Layton
2025-11-20 6:47 ` [PATCH 12/16] fs: factor out a sync_lazytime helper Christoph Hellwig
2025-11-20 6:47 ` [PATCH 13/16] fs: add a ->sync_lazytime method Christoph Hellwig
2025-11-20 6:47 ` [PATCH 14/16] fs: add support for non-blocking timestamp updates Christoph Hellwig
2025-11-20 6:47 ` [PATCH 15/16] xfs: implement ->sync_lazytime Christoph Hellwig
2025-11-20 6:47 ` [PATCH 16/16] xfs: enable non-blocking timestamp updates Christoph Hellwig
2025-11-20 14:16 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3933f47761845a016dcb6c851a99fdcedffc65d0.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=devel@lists.orangefs.org \
--cc=dsterba@suse.com \
--cc=gfs2@lists.linux.dev \
--cc=hch@lst.de \
--cc=hubcap@omnibond.com \
--cc=io-uring@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin@omnibond.com \
--cc=shr@fb.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).