Re: [PATCH 12/13] ovl: remove ovl_lock_rename_workdir()

NeilBrown
2026-02-06T01:18:33Z

On Thu, 05 Feb 2026, Amir Goldstein wrote:
> On Wed, Feb 4, 2026 at 6:09 AM NeilBrown <neilb@ownmail.net> wrote:
> >
> > From: NeilBrown <neil@brown.name>
> >
> > This function is unused.
> >
>
> I am confused.
> What was this "fix" fixing an unused function:
>
> e9c70084a64e5 ovl: fail ovl_lock_rename_workdir() if either target is unhashed
>
> What am I missing?
>

Commit 833d2b3a072f ("Add start_renaming_two_dentries()")

removed the last use of ovl_lock_rename_workdir() earlier, but in a
different branch.

e9c was committed upstream Nov 28th v6.18~7
833 was committed upstream Dec 1st v6.19-rc1~240

> Otherwise, feel free to add:
>
> Reviewed-by: Amir Goldstein <amir73il@gmail.com>

Thanks,
NeilBrown

>
> Thanks,
> Amir.
>