linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chandan Rajendra <chandan@linux.vnet.ibm.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Eryu Guan <eguan@redhat.com>, Miklos Szeredi <miklos@szeredi.hu>,
	linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 0/3] More nonsamefs d_ino test cleanups
Date: Mon, 20 Nov 2017 14:28:33 +0530	[thread overview]
Message-ID: <4911339.3rRr1GUodZ@localhost.localdomain> (raw)
In-Reply-To: <1511092589-29179-1-git-send-email-amir73il@gmail.com>

On Sunday, November 19, 2017 5:26:26 PM IST Amir Goldstein wrote:
> Chandan,
> 
> Please review my cleanups to overlay/041.
> I hope I did not "cleanup" anything important.
> This is the version of the test I used for testing xino feature,
> because it has improved test coverage for subdirs d_ino.
> 

The changes looks good.

Reviewed-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>

> If you approve of these changes, at least first 2 patches should
> be applied to the samefs test flavor (overlay/038), so the flavor
> difference remains only the layers setup used by the test.
> 
> Let me know if you want me to apply the changes to 038 myself or if
> you intend to do that yourself.

Amir, I will make the changes to overlay/038 and post them soon.

-- 
chandan

      parent reply	other threads:[~2017-11-20  8:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-19 11:56 [PATCH 0/3] More nonsamefs d_ino test cleanups Amir Goldstein
2017-11-19 11:56 ` [PATCH 1/3] overlay/041: code cleanup Amir Goldstein
2017-11-19 11:56 ` [PATCH 2/3] overlay/041: test consistent values of st_ino/d_ino for subdirs Amir Goldstein
2017-11-19 11:56 ` [PATCH 3/3] overlay/041: use user defined overlay mount option Amir Goldstein
2017-11-20  8:58 ` Chandan Rajendra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4911339.3rRr1GUodZ@localhost.localdomain \
    --to=chandan@linux.vnet.ibm.com \
    --cc=amir73il@gmail.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).