From: Jeff Layton <jlayton@kernel.org>
To: Christoph Hellwig <hch@lst.de>, Christian Brauner <brauner@kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
David Sterba <dsterba@suse.com>, Jan Kara <jack@suse.cz>,
Mike Marshall <hubcap@omnibond.com>,
Martin Brandenburg <martin@omnibond.com>,
Carlos Maiolino <cem@kernel.org>, Stefan Roesch <shr@fb.com>,
linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
gfs2@lists.linux.dev, io-uring@vger.kernel.org,
devel@lists.orangefs.org, linux-unionfs@vger.kernel.org,
linux-mtd@lists.infradead.org, linux-xfs@vger.kernel.org,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH 06/14] organgefs: use inode_update_timestamps directly
Date: Fri, 14 Nov 2025 09:06:33 -0500 [thread overview]
Message-ID: <4990df3273eb868aa21dde745c1ae2636af4cdd8.camel@kernel.org> (raw)
In-Reply-To: <20251114062642.1524837-7-hch@lst.de>
Please do fix the spelling of orangefs in the subject line. It'll be
hard to grep for otherwise...
On Fri, 2025-11-14 at 07:26 +0100, Christoph Hellwig wrote:
> Orangefs has no i_version handling and __orangefs_setattr already
> explicitly marks the inode dirty. So instead of the using
> the flags return value from generic_update_time, just call the
> lower level inode_update_timestamps helper directly.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/orangefs/inode.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/orangefs/inode.c b/fs/orangefs/inode.c
> index a01400cd41fd..55f6c8026812 100644
> --- a/fs/orangefs/inode.c
> +++ b/fs/orangefs/inode.c
> @@ -878,7 +878,9 @@ int orangefs_update_time(struct inode *inode, int flags)
>
> gossip_debug(GOSSIP_INODE_DEBUG, "orangefs_update_time: %pU\n",
> get_khandle_from_ino(inode));
> - flags = generic_update_time(inode, flags);
> +
> + flags = inode_update_timestamps(inode, flags);
> +
> memset(&iattr, 0, sizeof iattr);
> if (flags & S_ATIME)
> iattr.ia_valid |= ATTR_ATIME;
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2025-11-14 14:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 6:26 re-enable IOCB_NOWAIT writes to files Christoph Hellwig
2025-11-14 6:26 ` [PATCH 01/14] fs: refactor file timestamp update logic Christoph Hellwig
2025-11-17 6:32 ` Chaitanya Kulkarni
2025-11-14 6:26 ` [PATCH 02/14] fs: lift the FMODE_NOCMTIME check into file_update_time_flags Christoph Hellwig
2025-11-17 6:38 ` Chaitanya Kulkarni
2025-11-14 6:26 ` [PATCH 03/14] fs: export vfs_utimes Christoph Hellwig
2025-11-17 6:38 ` Chaitanya Kulkarni
2025-11-14 6:26 ` [PATCH 04/14] btrfs: use vfs_utimes to update file timestamps Christoph Hellwig
2025-11-14 6:26 ` [PATCH 05/14] fs: remove inode_update_time Christoph Hellwig
2025-11-17 6:59 ` Chaitanya Kulkarni
2025-11-19 6:25 ` Christoph Hellwig
2025-11-14 6:26 ` [PATCH 06/14] organgefs: use inode_update_timestamps directly Christoph Hellwig
2025-11-14 14:06 ` Jeff Layton [this message]
2025-11-14 15:26 ` Christoph Hellwig
2025-11-14 6:26 ` [PATCH 07/14] fs: return a negative error from generic_update_time Christoph Hellwig
2025-11-17 7:07 ` Chaitanya Kulkarni
2025-11-14 6:26 ` [PATCH 08/14] fs: exit early in generic_update_time when there is no work Christoph Hellwig
2025-11-14 6:26 ` [PATCH 09/14] fs: factor out a mark_inode_dirty_time helper Christoph Hellwig
2025-11-17 7:13 ` Chaitanya Kulkarni
2025-11-14 6:26 ` [PATCH 10/14] fs: factor out a sync_lazytime helper Christoph Hellwig
2025-11-17 7:38 ` Chaitanya Kulkarni
2025-11-19 6:28 ` Christoph Hellwig
2025-11-14 6:26 ` [PATCH 11/14] fs: add a ->sync_lazytime method Christoph Hellwig
2025-11-17 7:50 ` Chaitanya Kulkarni
2025-11-14 6:26 ` [PATCH 12/14] fs: add support for non-blocking timestamp updates Christoph Hellwig
2025-11-14 6:26 ` [PATCH 13/14] xfs: implement ->sync_lazytime Christoph Hellwig
2025-11-14 6:26 ` [PATCH 14/14] xfs: enable non-blocking timestamp updates Christoph Hellwig
2025-11-14 15:30 ` Christoph Hellwig
2025-11-16 8:23 ` Dave Chinner
2025-11-19 7:29 ` Christoph Hellwig
2025-11-14 14:04 ` re-enable IOCB_NOWAIT writes to files Jeff Layton
2025-11-14 15:28 ` Christoph Hellwig
2025-11-14 19:47 ` Jeff Layton
2025-11-14 17:01 ` Darrick J. Wong
2025-11-14 17:21 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4990df3273eb868aa21dde745c1ae2636af4cdd8.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=devel@lists.orangefs.org \
--cc=dsterba@suse.com \
--cc=gfs2@lists.linux.dev \
--cc=hch@lst.de \
--cc=hubcap@omnibond.com \
--cc=io-uring@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin@omnibond.com \
--cc=shr@fb.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).