[PATCH 1/1] overlayfs: restrict structs visible in current code module

[PATCH 1/1] overlayfs: restrict structs visible in current code module

[zyjzyj2000]

From: Zhu Yanjun <zyjzyj2000@gmail.com>

The structs ovl_cache_entry, ovl_dir_cache and ovl_dir_file
are only used in the file fs/overlayfs/readdir.c. As such,
the static keyword is inserted to define that object to be
only visible to the current code module during compilation.

Signed-off-by: Zhu Yanjun <zyjzyj2000@gmail.com>
---
 fs/overlayfs/readdir.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/overlayfs/readdir.c b/fs/overlayfs/readdir.c
index 70e9af5..362bc1c 100644
--- a/fs/overlayfs/readdir.c
+++ b/fs/overlayfs/readdir.c
@@ -17,7 +17,7 @@
 #include <linux/cred.h>
 #include "overlayfs.h"
 
-struct ovl_cache_entry {
+static struct ovl_cache_entry {
 	unsigned int len;
 	unsigned int type;
 	u64 ino;
@@ -28,13 +28,13 @@ struct ovl_cache_entry {
 	char name[];
 };
 
-struct ovl_dir_cache {
+static struct ovl_dir_cache {
 	long refcount;
 	u64 version;
 	struct list_head entries;
 };
 
-struct ovl_readdir_data {
+static struct ovl_readdir_data {
 	struct dir_context ctx;
 	bool is_merge;
 	struct rb_root root;
@@ -45,7 +45,7 @@ struct ovl_readdir_data {
 	int err;
 };
 
-struct ovl_dir_file {
+static struct ovl_dir_file {
 	bool is_real;
 	bool is_upper;
 	struct ovl_dir_cache *cache;
-- 
1.7.9.5

Re: [PATCH 1/1] overlayfs: restrict structs visible in current code module

[zhuyj]

Sorry. Please ignore this patch.

Zhu Yanjun

On 01/04/2016 05:42 PM, zyjzyj2000@gmail.com wrote:
> From: Zhu Yanjun <zyjzyj2000@gmail.com>
>
> The structs ovl_cache_entry, ovl_dir_cache and ovl_dir_file
> are only used in the file fs/overlayfs/readdir.c. As such,
> the static keyword is inserted to define that object to be
> only visible to the current code module during compilation.
>
> Signed-off-by: Zhu Yanjun <zyjzyj2000@gmail.com>
> ---
>   fs/overlayfs/readdir.c |    8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/overlayfs/readdir.c b/fs/overlayfs/readdir.c
> index 70e9af5..362bc1c 100644
> --- a/fs/overlayfs/readdir.c
> +++ b/fs/overlayfs/readdir.c
> @@ -17,7 +17,7 @@
>   #include <linux/cred.h>
>   #include "overlayfs.h"
>   
> -struct ovl_cache_entry {
> +static struct ovl_cache_entry {
>   	unsigned int len;
>   	unsigned int type;
>   	u64 ino;
> @@ -28,13 +28,13 @@ struct ovl_cache_entry {
>   	char name[];
>   };
>   
> -struct ovl_dir_cache {
> +static struct ovl_dir_cache {
>   	long refcount;
>   	u64 version;
>   	struct list_head entries;
>   };
>   
> -struct ovl_readdir_data {
> +static struct ovl_readdir_data {
>   	struct dir_context ctx;
>   	bool is_merge;
>   	struct rb_root root;
> @@ -45,7 +45,7 @@ struct ovl_readdir_data {
>   	int err;
>   };
>   
> -struct ovl_dir_file {
> +static struct ovl_dir_file {
>   	bool is_real;
>   	bool is_upper;
>   	struct ovl_dir_cache *cache;