From: Paul Moore <paul@paul-moore.com>
To: David Disseldorp <ddiss@suse.de>, selinux@vger.kernel.org
Cc: linux-unionfs@vger.kernel.org
Subject: Re: [PATCH v2] selinux: only filter copy-up xattrs following initialization
Date: Fri, 02 Feb 2024 13:53:06 -0500 [thread overview]
Message-ID: <5ec703e783241a5a6d440cef68a6fcb9@paul-moore.com> (raw)
In-Reply-To: <20240202064048.29881-1-ddiss@suse.de>
On Feb 2, 2024 David Disseldorp <ddiss@suse.de> wrote:
>
> Extended attribute copy-up functionality added via 19472b69d639d
> ("selinux: Implementation for inode_copy_up_xattr() hook") sees
> "security.selinux" contexts dropped, instead relying on contexts
> applied via the inode_copy_up() hook.
>
> When copy-up takes place during early boot, prior to selinux
> initialization / policy load, the context stripping can be unwanted
> and unexpected.
>
> With this change, filtering of "security.selinux" xattrs will only occur
> after selinux initialization.
>
> Signed-off-by: David Disseldorp <ddiss@suse.de>
> ---
> Changes since v1:
> - drop RFC
> - slightly rework commit message and preceeding comment
>
> security/selinux/hooks.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Merged into selinux/dev, thanks for following up on this.
--
paul-moore.com
prev parent reply other threads:[~2024-02-02 18:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 6:40 [PATCH v2] selinux: only filter copy-up xattrs following initialization David Disseldorp
2024-02-02 18:53 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ec703e783241a5a6d440cef68a6fcb9@paul-moore.com \
--to=paul@paul-moore.com \
--cc=ddiss@suse.de \
--cc=linux-unionfs@vger.kernel.org \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox