From: David Howells <dhowells@redhat.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: dhowells@redhat.com, linux-unionfs@vger.kernel.org,
Amir Goldstein <amir73il@gmail.com>,
Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [RFC PATCH] ovl: don't follow redirects if redirect_dir=off
Date: Tue, 05 Dec 2017 14:36:13 +0000 [thread overview]
Message-ID: <7051.1512484573@warthog.procyon.org.uk> (raw)
In-Reply-To: <20171205133707.GA24303@veci.piliscsaba.redhat.com>
Miklos Szeredi <miklos@szeredi.hu> wrote:
> +static const bool ovl_redirect_follow_def =
> + IS_ENABLED(CONFIG_OVERLAY_FS_REDIRECT_ALWAYS_FOLLOW);
This would be better as a #def'd constant rather than a constant variable so
that it can be used to optimise stuff away and so that it won't take up
.rodata space.
David
next prev parent reply other threads:[~2017-12-05 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 13:37 [RFC PATCH] ovl: don't follow redirects if redirect_dir=off Miklos Szeredi
2017-12-05 14:36 ` David Howells [this message]
2017-12-05 15:18 ` Miklos Szeredi
2017-12-05 15:01 ` Amir Goldstein
2017-12-05 15:19 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7051.1512484573@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=amir73il@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox