From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Salyzyn Subject: Re: [PATCH v7] Add flags option to get xattr method paired to __vfs_getxattr Date: Tue, 27 Aug 2019 07:54:44 -0700 Message-ID: <8468b22d-05b7-47d3-eb93-2c71dafea3ee@android.com> References: <20190820180716.129882-1-salyzyn@android.com> <20190827141952.GB10098@quack2.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190827141952.GB10098@quack2.suse.cz> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org To: Jan Kara Cc: Latchesar Ionkov , Eric Sandeen , Mike Marshall , linux-xfs@vger.kernel.org, James Morris , devel@lists.orangefs.org, Eric Van Hensbergen , Joel Becker , Trond Myklebust , Mathieu Malaterre , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Jan Kara , Casey Schaufler , Andrew Morton , Dave Kleikamp , linux-doc@vger.kernel.org, Jeff Layton , Chao Yu , Mimi Zohar , "David S. Miller" , linux-cifs@vger.kernel.org, Paul Moore , "Darrick J. Wong" , Hugh Dickins List-Id: linux-unionfs@vger.kernel.org On 8/27/19 7:19 AM, Jan Kara wrote: > On Tue 20-08-19 11:06:48, Mark Salyzyn wrote: >> diff --git a/Documentation/filesystems/Locking b/Documentation/filesystems/Locking >> index 204dd3ea36bb..e2687f21c7d6 100644 >> --- a/Documentation/filesystems/Locking >> +++ b/Documentation/filesystems/Locking >> @@ -101,12 +101,10 @@ of the locking scheme for directory operations. >> ----------------------- xattr_handler operations ----------------------- >> prototypes: >> bool (*list)(struct dentry *dentry); >> - int (*get)(const struct xattr_handler *handler, struct dentry *dentry, >> - struct inode *inode, const char *name, void *buffer, >> - size_t size); >> - int (*set)(const struct xattr_handler *handler, struct dentry *dentry, >> - struct inode *inode, const char *name, const void *buffer, >> - size_t size, int flags); >> + int (*get)(const struct xattr_handler *handler, >> + struct xattr_gs_flags); >> + int (*set)(const struct xattr_handler *handler, >> + struct xattr_gs_flags); > The prototype here is really "struct xattr_gs_flags *args", isn't it? > Otherwise feel free to add: > > Reviewed-by: Jan Kara > > for the ext2, ext4, ocfs2, reiserfs, and the generic fs/* bits. > > Honza Thanks and good catch, will respin with a fix to the documentation shortly. -- Mark ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/