From: NeilBrown <neilb@suse.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
linux-unionfs@vger.kernel.org, linux-doc@vger.kernel.org,
Miklos Szeredi <miklos@szeredi.hu>
Subject: Re: [PATCH] ovl: fix reStructuredText syntax errors in documentation
Date: Fri, 16 Dec 2016 08:12:04 +1100 [thread overview]
Message-ID: <874m24yk0r.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <CAOQ4uxg8s_1ATqFFD6__2dez9-VYqR2NpFQ5iU8zvCDYLib0Pw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2786 bytes --]
On Thu, Dec 15 2016, Amir Goldstein wrote:
> On Thu, Dec 8, 2016 at 9:49 AM, Amir Goldstein <amir73il@gmail.com> wrote:
>> - Fix broken long line block quote
>> - Fix missing newline before bullets list
>> - Use correct numbered list syntax
>>
>
> Ping.
>
> Neil,
> I found these syntax errors when I posted your page on my wiki:
> https://github.com/amir73il/overlayfs/wiki/Overlayfs-overview
>
> Not sure if this patch should go through Miklos's tree or John's tree,
> but is surely needs the ACK from you.
Does it? It is purely format changes which don't change the meaning in
any way, so I felt it had little relevant to me.
However I'm happy to provide an:
Acked-by: NeilBrown <neilb@suse.com>
if you find that useful.
NeilBrown
>
> Thanks,
> Amir.
>
>> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
>> ---
>> Documentation/filesystems/overlayfs.txt | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/filesystems/overlayfs.txt b/Documentation/filesystems/overlayfs.txt
>> index fb6f307..634d03e 100644
>> --- a/Documentation/filesystems/overlayfs.txt
>> +++ b/Documentation/filesystems/overlayfs.txt
>> @@ -66,7 +66,7 @@ At mount time, the two directories given as mount options "lowerdir" and
>> "upperdir" are combined into a merged directory:
>>
>> mount -t overlay overlay -olowerdir=/lower,upperdir=/upper,\
>> -workdir=/work /merged
>> + workdir=/work /merged
>>
>> The "workdir" needs to be an empty directory on the same filesystem
>> as upperdir.
>> @@ -118,6 +118,7 @@ programs.
>>
>> seek offsets are assigned sequentially when the directories are read.
>> Thus if
>> +
>> - read part of a directory
>> - remember an offset, and close the directory
>> - re-open the directory some time later
>> @@ -137,12 +138,12 @@ When renaming a directory that is on the lower layer or merged (i.e. the
>> directory was not created on the upper layer to start with) overlayfs can
>> handle it in two different ways:
>>
>> -1) return EXDEV error: this error is returned by rename(2) when trying to
>> +1. return EXDEV error: this error is returned by rename(2) when trying to
>> move a file or directory across filesystem boundaries. Hence
>> applications are usually prepared to hande this error (mv(1) for example
>> recursively copies the directory tree). This is the default behavior.
>>
>> -2) If the "redirect_dir" feature is enabled, then the directory will be
>> +2. If the "redirect_dir" feature is enabled, then the directory will be
>> copied up (but not the contents). Then the "trusted.overlay.redirect"
>> extended attribute is set to the path of the original location from the
>> root of the overlay. Finally the directory is moved to the new
>> --
>> 2.7.4
>>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2016-12-15 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 7:49 [PATCH] ovl: fix reStructuredText syntax errors in documentation Amir Goldstein
2016-12-15 7:58 ` Amir Goldstein
2016-12-15 14:25 ` Jonathan Corbet
2016-12-15 21:12 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m24yk0r.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=amir73il@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox