Re: [PATCH] ovl: Fix for filesystems without POSIX ACL support

[Miklos Szeredi <miklos@szeredi.hu>]

On Tue, Sep 6, 2016 at 2:13 PM, Andreas Gruenbacher <agruenba@redhat.com> wrote:
> On filesystems without POSIX ACL support such as ubifs, trying to remove
> a POSIX ACL with vfs_removexattr will result in -EOPNOTSUPP.  Don't fail
> in that case.
>

Yep, already fixed in overlayfs-linus.

Thanks,
Miklos

> Reported-by: Richard Weinberger <richard@nod.at>
> Fixes: c11b9fdd
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> ---
>  fs/overlayfs/super.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
> index a4585f9..e2a94a2 100644
> --- a/fs/overlayfs/super.c
> +++ b/fs/overlayfs/super.c
> @@ -835,11 +835,11 @@ retry:
>                         goto out_dput;
>
>                 err = vfs_removexattr(work, XATTR_NAME_POSIX_ACL_DEFAULT);
> -               if (err && err != -ENODATA)
> +               if (err && err != -ENODATA && err != -EOPNOTSUPP)
>                         goto out_dput;
>
>                 err = vfs_removexattr(work, XATTR_NAME_POSIX_ACL_ACCESS);
> -               if (err && err != -ENODATA)
> +               if (err && err != -ENODATA && err != -EOPNOTSUPP)
>                         goto out_dput;
>
>                 /* Clear any inherited mode bits */
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html