* [PATCH] ovl: Fix for filesystems without POSIX ACL support
@ 2016-09-06 12:13 Andreas Gruenbacher
2016-09-06 12:47 ` Miklos Szeredi
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Gruenbacher @ 2016-09-06 12:13 UTC (permalink / raw)
To: Miklos Szeredi; +Cc: linux-unionfs, Andreas Gruenbacher
On filesystems without POSIX ACL support such as ubifs, trying to remove
a POSIX ACL with vfs_removexattr will result in -EOPNOTSUPP. Don't fail
in that case.
Reported-by: Richard Weinberger <richard@nod.at>
Fixes: c11b9fdd
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
fs/overlayfs/super.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index a4585f9..e2a94a2 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -835,11 +835,11 @@ retry:
goto out_dput;
err = vfs_removexattr(work, XATTR_NAME_POSIX_ACL_DEFAULT);
- if (err && err != -ENODATA)
+ if (err && err != -ENODATA && err != -EOPNOTSUPP)
goto out_dput;
err = vfs_removexattr(work, XATTR_NAME_POSIX_ACL_ACCESS);
- if (err && err != -ENODATA)
+ if (err && err != -ENODATA && err != -EOPNOTSUPP)
goto out_dput;
/* Clear any inherited mode bits */
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ovl: Fix for filesystems without POSIX ACL support
2016-09-06 12:13 [PATCH] ovl: Fix for filesystems without POSIX ACL support Andreas Gruenbacher
@ 2016-09-06 12:47 ` Miklos Szeredi
0 siblings, 0 replies; 2+ messages in thread
From: Miklos Szeredi @ 2016-09-06 12:47 UTC (permalink / raw)
To: Andreas Gruenbacher; +Cc: linux-unionfs@vger.kernel.org
On Tue, Sep 6, 2016 at 2:13 PM, Andreas Gruenbacher <agruenba@redhat.com> wrote:
> On filesystems without POSIX ACL support such as ubifs, trying to remove
> a POSIX ACL with vfs_removexattr will result in -EOPNOTSUPP. Don't fail
> in that case.
>
Yep, already fixed in overlayfs-linus.
Thanks,
Miklos
> Reported-by: Richard Weinberger <richard@nod.at>
> Fixes: c11b9fdd
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> ---
> fs/overlayfs/super.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
> index a4585f9..e2a94a2 100644
> --- a/fs/overlayfs/super.c
> +++ b/fs/overlayfs/super.c
> @@ -835,11 +835,11 @@ retry:
> goto out_dput;
>
> err = vfs_removexattr(work, XATTR_NAME_POSIX_ACL_DEFAULT);
> - if (err && err != -ENODATA)
> + if (err && err != -ENODATA && err != -EOPNOTSUPP)
> goto out_dput;
>
> err = vfs_removexattr(work, XATTR_NAME_POSIX_ACL_ACCESS);
> - if (err && err != -ENODATA)
> + if (err && err != -ENODATA && err != -EOPNOTSUPP)
> goto out_dput;
>
> /* Clear any inherited mode bits */
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-06 12:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-06 12:13 [PATCH] ovl: Fix for filesystems without POSIX ACL support Andreas Gruenbacher
2016-09-06 12:47 ` Miklos Szeredi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).