From: Miklos Szeredi <miklos@szeredi.hu>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
Vivek Goyal <vgoyal@redhat.com>,
"linux-unionfs@vger.kernel.org" <linux-unionfs@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ovl: fix link error without POSIX ACL
Date: Thu, 14 Jul 2016 14:16:01 +0200 [thread overview]
Message-ID: <CAJfpegtdGL1+ZeEUbLHgdQjQUWprYM=OqsZyU+sLsJp-vftPyQ@mail.gmail.com> (raw)
In-Reply-To: <20160714095512.768359-1-arnd@arndb.de>
On Thu, Jul 14, 2016 at 11:54 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The latest fix for ACL on overlayfs introduced a link error:
>
> fs/built-in.o: In function `ovl_posix_acl_xattr_set':
> file.c:(.text+0x6b320): undefined reference to `posix_acl_from_xattr'
>
> posix_acl_from_xattr doesn't have a 'static inline' implementation when
> CONFIG_FS_POSIX_ACL is disabled, and I could not come up with an obvious
> way to do it.
>
> This instead avoids the link error by defining two sets of ACL operations
> and letting the compiler drop one of the two at compile time depending
> on CONFIG_FS_POSIX_ACL. This avoids all references to the ACL code,
> also leading to smaller code.
Thanks, pushed.
Miklos
prev parent reply other threads:[~2016-07-14 12:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 9:54 [PATCH] ovl: fix link error without POSIX ACL Arnd Bergmann
2016-07-14 12:16 ` Miklos Szeredi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJfpegtdGL1+ZeEUbLHgdQjQUWprYM=OqsZyU+sLsJp-vftPyQ@mail.gmail.com' \
--to=miklos@szeredi.hu \
--cc=arnd@arndb.de \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).