linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH 3/3] ovl: compact nested ovl_fh
Date: Wed, 24 Oct 2018 16:34:56 +0200	[thread overview]
Message-ID: <CAJfpegu-MVikDXiD3o1Lx8ZyAitFpMnB5kVp9neJneM84L8=aA@mail.gmail.com> (raw)
In-Reply-To: <20180903061211.20830-4-amir73il@gmail.com>

On Mon, Sep 3, 2018 at 8:12 AM, Amir Goldstein <amir73il@gmail.com> wrote:
> When encoding a file handle from lower nested overlayfs, prepending
> another ovl_fh header for nested overlay file handle adds no new
> information for decoding.  Instead, we just set a 'nested' flag in ovl_fh
> header for nested file handle, so we know to distinguish between real
> upper file handle that should be decoded from real upper layer and
> nested upper file handle that should be decoded from nested lower layer.
> For the maximum allowed overlay nesting depth of 1, one bit is enough.

This is an optimization, right?

What are the user-visible advantages that would justify the added complexity?

Thanks,
Miklos

  reply	other threads:[~2018-10-24 14:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-03  6:12 [PATCH 0/3] Enable new features for more overlayfs setups Amir Goldstein
2018-09-03  6:12 ` [PATCH 1/3] ovl: relax requirement for non null uuid of lower fs Amir Goldstein
2018-10-24 14:16   ` Miklos Szeredi
2018-10-24 15:29     ` Amir Goldstein
2018-09-03  6:12 ` [PATCH 2/3] ovl: disable xino for some nested overlay cases Amir Goldstein
2018-10-24 14:30   ` Miklos Szeredi
2018-10-24 15:03     ` Amir Goldstein
2018-10-24 15:19       ` Miklos Szeredi
2018-10-24 16:11         ` Amir Goldstein
2018-09-03  6:12 ` [PATCH 3/3] ovl: compact nested ovl_fh Amir Goldstein
2018-10-24 14:34   ` Miklos Szeredi [this message]
2018-10-24 17:56     ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJfpegu-MVikDXiD3o1Lx8ZyAitFpMnB5kVp9neJneM84L8=aA@mail.gmail.com' \
    --to=miklos@szeredi.hu \
    --cc=amir73il@gmail.com \
    --cc=linux-unionfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).