linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Derek McGowan <dmcg@drizz.net>
Cc: "linux-unionfs@vger.kernel.org" <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH] ovl: fix copy up opaque directory
Date: Mon, 8 Aug 2016 15:21:57 +0200	[thread overview]
Message-ID: <CAJfpegugp-t55NU5L8qRA2Fc0a7ttraqkYQgoHp7FosiE7f52w@mail.gmail.com> (raw)
In-Reply-To: <1470337477-7297-1-git-send-email-dmcg@drizz.net>

On Thu, Aug 4, 2016 at 9:04 PM, Derek McGowan <dmcg@drizz.net> wrote:
> When a copy up of a directory occurs which has the opaque xattr set, the
> xattr remains in the upper directory. The immediate behavior with overlayfs
> is that the upper directory is not treated as opaque, however after a
> remount the opaque flag is used and upper directory is treated as opaque.
> This causes files created in the lower layer to be hidden when using
> multiple lower directories. This change fixes the behavior to remove the
> opaque flag when an opaque directory is copied up.

Thanks for the report.

I redid the patch to instead of "copy + check + remove" the xattr it
simply doesn't copy.

Updated patch pushed to:

  git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git for-linus

Thanks,
Miklos

      reply	other threads:[~2016-08-08 13:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-04 19:04 [PATCH] ovl: fix copy up opaque directory Derek McGowan
2016-08-08 13:21 ` Miklos Szeredi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJfpegugp-t55NU5L8qRA2Fc0a7ttraqkYQgoHp7FosiE7f52w@mail.gmail.com \
    --to=miklos@szeredi.hu \
    --cc=dmcg@drizz.net \
    --cc=linux-unionfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).