Re: [linux-next:master 4258/4954] fs/overlayfs/file.c:234:57: warning: omitting the parameter name in a function definition is a C23 extension

Re: [linux-next:master 4258/4954] fs/overlayfs/file.c:234:57: warning: omitting the parameter name in a function definition is a C23 extension

[Amir Goldstein]

On Wed, Oct 16, 2024 at 12:29 PM kernel test robot <lkp@intel.com> wrote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   15e7d45e786a62a211dd0098fee7c57f84f8c681
> commit: 291f180e5929ec636ecffd8a0bba00da907e0f89 [4258/4954] fs: pass offset and result to backing_file end_write() callback
> config: i386-buildonly-randconfig-001-20241016 (https://download.01.org/0day-ci/archive/20241016/202410161847.oG293ywD-lkp@intel.com/config)
> compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241016/202410161847.oG293ywD-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202410161847.oG293ywD-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> >> fs/overlayfs/file.c:234:57: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]
>      234 | static void ovl_file_end_write(struct file *file, loff_t, ssize_t)
>          |                                                         ^
>    fs/overlayfs/file.c:234:66: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]
>      234 | static void ovl_file_end_write(struct file *file, loff_t, ssize_t)
>          |                                                                  ^
>    2 warnings generated.
>
>
> vim +234 fs/overlayfs/file.c
>
>    233
>  > 234  static void ovl_file_end_write(struct file *file, loff_t, ssize_t)
>    235  {
>    236          ovl_file_modified(file);
>    237  }
>    238
>

Miklos,

Could you fix that in your branch?
Preferably also the fuse_passthrough_end_write() function in the
first patch, so there is no build warning mid series.

Thanks,
Amir.

Re: [linux-next:master 4258/4954] fs/overlayfs/file.c:234:57: warning: omitting the parameter name in a function definition is a C23 extension

[Miklos Szeredi]

On Wed, 16 Oct 2024 at 12:41, Amir Goldstein <amir73il@gmail.com> wrote:

> Preferably also the fuse_passthrough_end_write() function in the
> first patch, so there is no build warning mid series.

Fixed.

Thanks,
Miklos