From: Eddie Horng <eddiehorng.tw@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Amir Goldstein <amir73il@gmail.com>,
overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH] ovl: support stacked SEEK_HOLE/SEEK_DATA
Date: Wed, 27 Feb 2019 14:49:19 +0800 [thread overview]
Message-ID: <CALLuPvq6ctYokpJS5+iJSFsy_epLjSCAtOn=6UepEsW3SXyJ9w@mail.gmail.com> (raw)
In-Reply-To: <CAJfpegtmcYdTM0OjYyMUjK_nZnLrdE=z02TFe40sZuKCpQcXkA@mail.gmail.com>
> > > > OK. What about Eddie's question:
> > > > If realinode is nested overlay inode, then realinode->i_sb->s_maxbytes
> > > > will not reflect the "real" inode's maxbytes.
> > > > Not to mention other crazy things that filesystems may do for SET/CUR/END.
> > > > Take ext4_llseek() for example, for the less common case (ext3 format inode)
> > > > the value of inode->i_sb->s_maxbytes is not used as maxbytes, but a smaller
> > > > value.
> > > >
Hi Amir,
Thanks your detail information and the patch.
I ran into this issue by using a proprietary stacked file system as lower
and the file system does not initial it's s_maxbytes, therefore
caused file larger than 2GB fails lseek. A quick workaround is to set the fs
s_maxbytes to MAX_LFS_FILESIZE, but like you said, for certain cases this might
be a problem.
I have verified this patch with same configuration and the lower inode
f_op->llseek
does get invoked, looks like enough to resolve my particular case.
thanks,
Eddie
prev parent reply other threads:[~2019-02-27 6:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 15:27 [PATCH] ovl: support stacked SEEK_HOLE/SEEK_DATA Amir Goldstein
2019-02-26 16:07 ` Miklos Szeredi
2019-02-26 17:20 ` Amir Goldstein
2019-02-26 20:32 ` Miklos Szeredi
2019-02-26 21:16 ` Amir Goldstein
2019-02-26 21:20 ` Miklos Szeredi
2019-02-27 6:49 ` Eddie Horng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALLuPvq6ctYokpJS5+iJSFsy_epLjSCAtOn=6UepEsW3SXyJ9w@mail.gmail.com' \
--to=eddiehorng.tw@gmail.com \
--cc=amir73il@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).