From: Amir Goldstein <amir73il@gmail.com>
To: Chandan Rajendra <chandan@linux.vnet.ibm.com>
Cc: fstests <fstests@vger.kernel.org>,
overlayfs <linux-unionfs@vger.kernel.org>,
Eryu Guan <eguan@redhat.com>
Subject: Re: [PATCH] overlay/038: Miscellaneous fixes
Date: Sun, 15 Oct 2017 16:10:10 +0300 [thread overview]
Message-ID: <CAOQ4uxh9tbhaOa+=qkBngq_ZydbYrHn=g2H7AAS3EcM3HuxrJQ@mail.gmail.com> (raw)
In-Reply-To: <CAOQ4uxgJrexT9AHe4rKD-AQhsd70EyFLn2tFW++4MEUQfpP+Jw@mail.gmail.com>
On Sun, Oct 8, 2017 at 9:39 PM, Amir Goldstein <amir73il@gmail.com> wrote:
> On Sun, Oct 8, 2017 at 2:25 PM, Chandan Rajendra
> <chandan@linux.vnet.ibm.com> wrote:
>> This commit removes the redundant chown operation which was supposed to
>> cause the test file to be copied up. Also, _overlay_scratch_unmount() is
>> used to unmount the overlay filesystem rather than invoking $UMOUNT_PROG.
>>
>> Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
>> ---
>> tests/overlay/038 | 8 +++-----
>> 1 file changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/tests/overlay/038 b/tests/overlay/038
>> index 57281fa..148995b 100755
>> --- a/tests/overlay/038
>> +++ b/tests/overlay/038
>> @@ -1,7 +1,7 @@
>> #! /bin/bash
>> # FSQA Test No. 038
>> #
>> -# Test constant d_ino numbers
>> +# Test consistent d_ino numbers for samefs setup.
>> #
>> #-----------------------------------------------------------------------
>> #
>> @@ -102,10 +102,8 @@ current_d=$($here/src/t_dir_type $impure_dir $impure_dir_st_ino)
>> [[ $current_d == ". d" ]] || \
>> echo "Before dir becomes impure: Invalid d_ino reported for ."
>>
>> -chown -h 100 $SCRATCH_MNT/test_file
>> -test_file_st_ino=$(stat -c '%i' $SCRATCH_MNT/test_file)
>> -
>> mv $SCRATCH_MNT/test_file $impure_dir
>> +test_file_st_ino=$(stat -c '%i' $impure_dir/test_file)
>>
>> impure=$($GETFATTR_PROG --absolute-names --only-values -n 'trusted.overlay.impure' \
>> $upperdir/test_dir/impure_dir)
>> @@ -187,7 +185,7 @@ parent_d=$($here/src/t_dir_type $SCRATCH_MNT/test_dir/pure_lower_dir $test_dir_s
>> [[ $parent_d == ".. d" ]] || \
>> echo "Pure lower in dir which has another lower layer: Invalid d_ino reported for .."
>>
>> -$UMOUNT_PROG $SCRATCH_MNT
>> +_overlay_scratch_unmount
>>
>
> Neither variant is really needed at end of test but fine.
>
This got merged with _overlay_scratch_unmount which is not intended to be used
directly. I overlooked this in review. Not really a problem though.
Should probably remove this final umount from the test in a cleanup patch.
Amir.
prev parent reply other threads:[~2017-10-15 13:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-08 11:25 [PATCH] overlay/038: Miscellaneous fixes Chandan Rajendra
2017-10-08 18:39 ` Amir Goldstein
2017-10-15 13:10 ` Amir Goldstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOQ4uxh9tbhaOa+=qkBngq_ZydbYrHn=g2H7AAS3EcM3HuxrJQ@mail.gmail.com' \
--to=amir73il@gmail.com \
--cc=chandan@linux.vnet.ibm.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).