From: Amir Goldstein <amir73il@gmail.com>
To: "zhangyi (F)" <yi.zhang@huawei.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH v6 0/3] Overlayfs fixes for exposed whiteouts
Date: Wed, 1 Nov 2017 08:08:42 +0200 [thread overview]
Message-ID: <CAOQ4uxhkMB1_=r0MH-Fb6W01BCh-ch9UnWr1J64PrrOdBbN+WQ@mail.gmail.com> (raw)
In-Reply-To: <0b81aec4-beb5-6c01-3093-a439c37df462@huawei.com>
On Wed, Nov 1, 2017 at 5:12 AM, zhangyi (F) <yi.zhang@huawei.com> wrote:
> On 2017/11/1 5:45, Amir Goldstein Wrote:
>> Miklos,
>>
>> Let's call my previous version v5 (Zhangyi's last post was v4).
>>
>> Changes since v5:
>> - Split ovl_check_empty_and_clear() changes from bug fix patch
>> - Cache "origin" xattr of non-merge dir in inode flag OVL_WHITEOUTS
>> (OVL_ORIGIN would have been too confusing)
>> - Replace layer idx with is_upper boolean
>>
>> I tested these changes with upstream xfstest overlay/031 by Zhangyi.
>> Pushed to ovl-whiteouts branch [1] and rebased the non-samefs patches
>> on top of it [2].
>>
>
> All these three patches looks good to me, and I tested these too.
>
Thanks for review and testing!
Oh! I messed up the authorship of your patch when I split it.
Pushed fixed version with description of my changes to [1].
Miklos,
Please take updated commits from my branch.
Thanks,
Amir.
>>
>> [1] https://github.com/amir73il/linux/commits/ovl-whiteouts
>> [1] https://github.com/amir73il/linux/commits/overlayfs-devel
>>
>> Amir Goldstein (3):
>> ovl: no direct iteration for dir with origin xattr
>> ovl: simplify ovl_check_empty_and_clear()
>> ovl: fix rmdir problem on non-merge dir with origin xattr
>>
>> fs/overlayfs/dir.c | 18 ++++++++++------
>> fs/overlayfs/inode.c | 5 +++++
>> fs/overlayfs/overlayfs.h | 4 ++++
>> fs/overlayfs/readdir.c | 56 ++++++++++++++++++++++++++++++++++++++----------
>> fs/overlayfs/util.c | 13 +++++++++++
>> 5 files changed, 79 insertions(+), 17 deletions(-)
>>
>
prev parent reply other threads:[~2017-11-01 6:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 21:45 [PATCH v6 0/3] Overlayfs fixes for exposed whiteouts Amir Goldstein
2017-10-31 21:45 ` [PATCH v6 1/3] ovl: no direct iteration for dir with origin xattr Amir Goldstein
2017-10-31 21:45 ` [PATCH v6 2/3] ovl: simplify ovl_check_empty_and_clear() Amir Goldstein
2017-10-31 21:45 ` [PATCH v6 3/3] ovl: fix rmdir problem on non-merge dir with origin xattr Amir Goldstein
2017-11-01 3:12 ` [PATCH v6 0/3] Overlayfs fixes for exposed whiteouts zhangyi (F)
2017-11-01 6:08 ` Amir Goldstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOQ4uxhkMB1_=r0MH-Fb6W01BCh-ch9UnWr1J64PrrOdBbN+WQ@mail.gmail.com' \
--to=amir73il@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).