From: Amir Goldstein <amir73il@gmail.com>
To: "zhangyi (F)" <yi.zhang@huawei.com>
Cc: fstests <fstests@vger.kernel.org>, Eryu Guan <eguan@redhat.com>,
overlayfs <linux-unionfs@vger.kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>,
miaoxie@huawei.com
Subject: Re: [PATCH xfstests 2/2] overlay: test chattr lower file in overlay
Date: Thu, 14 Sep 2017 16:07:25 +0300 [thread overview]
Message-ID: <CAOQ4uxhqzXQ9uE-OyDpzZybjPp2odKGMtQJVQk-a66wi9gsrpg@mail.gmail.com> (raw)
In-Reply-To: <1505390643-6981-2-git-send-email-yi.zhang@huawei.com>
On Thu, Sep 14, 2017 at 3:04 PM, zhangyi (F) <yi.zhang@huawei.com> wrote:
> chattr with [iap..] attributes open file for read-only and
> invoke ioctl(). If we chattr a lower file in overlay, it
> will get the lower file but not trigger copy-up, so ioctl()
> lead to modification of that lower file incorrectly. Add this
> test for this case.
>
> Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
> ---
Looks good.
Thanks
next prev parent reply other threads:[~2017-09-14 13:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 12:04 [PATCH xfstests 1/2] overlay: test relatime for directories zhangyi (F)
2017-09-14 12:04 ` [PATCH xfstests 2/2] overlay: test chattr lower file in overlay zhangyi (F)
2017-09-14 13:07 ` Amir Goldstein [this message]
2017-09-14 13:31 ` Eryu Guan
2017-09-15 1:06 ` zhangyi (F)
2017-09-14 13:07 ` [PATCH xfstests 1/2] overlay: test relatime for directories Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQ4uxhqzXQ9uE-OyDpzZybjPp2odKGMtQJVQk-a66wi9gsrpg@mail.gmail.com \
--to=amir73il@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=miklos@szeredi.hu \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).