From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Morris Subject: Re: [PATCH] Add flags option to get xattr method paired to __vfs_getxattr Date: Fri, 16 Aug 2019 08:27:07 +1000 (AEST) Message-ID: References: <20190812193320.200472-1-salyzyn@android.com> <20190813084801.GA972@kroah.com> <69889dec-5440-1472-ed57-380f45547581@android.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <69889dec-5440-1472-ed57-380f45547581@android.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org To: Mark Salyzyn Cc: Latchesar Ionkov , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, kernel-team@android.com, linux-integrity@vger.kernel.org, Martin Brandenburg , samba-technical@lists.samba.org, Dominique Martinet , Chao Yu , Mimi Zohar , linux-unionfs@vger.kernel.org, David Howells , Chris Mason , "David S. Miller" , Andreas Dilger , Eric Paris , netdev@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, Mike Marshall , linux-xfs@vger.kernel.org, Andreas Gruenbacher , Sage Weil , Miklos Szeredi , Richard Weinberger Mark Fasheh List-Id: linux-unionfs@vger.kernel.org On Thu, 15 Aug 2019, Mark Salyzyn wrote: > Good Idea, but using the same argument structure for set and get I would be > concerned about the loss of compiler protection for the buffer argument; Agreed, I missed that. > struct getxattr_args { > struct dentry *dentry; > struct inode *inode; > const char *name; > void *buffer; > size_t size; > int flags; Does 'get' need flags? -- James Morris ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/