From: Zorro Lang <zlang@kernel.org>
To: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
Cc: fstests@vger.kernel.org, Amir Goldstein <amir73il@gmail.com>,
linux-unionfs@vger.kernel.org
Subject: Re: [PATCH v2] overlay/081: add missing _require_scratch check
Date: Wed, 2 Sep 2026 13:51:08 +0800 [thread overview]
Message-ID: <ape4hyfwsv5LrYxB@zlang-mailbox> (raw)
In-Reply-To: <20260901132438.759-1-prabhakar.pujeri@dell.com>
On Tue, Sep 01, 2026 at 01:24:38PM +0000, Prabhakar Pujeri wrote:
> The test runs _scratch_mkfs without first requiring a scratch device, so it fails messily instead of skipping when no scratch device is configured. Add _require_scratch so the test skips cleanly when no scratch device is present.
>
> Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
> Reviewed-by: Amir Goldstein <amir73il@gmail.com>
> ---
> Changes in v2:
> - Use _require_scratch instead of _require_scratch_nocheck and drop the
> comment copied from overlay/079/080, which does not apply to this test.
> Add Amir's Reviewed-by.
> v1: https://lore.kernel.org/fstests/20260831104154.2256-1-prabhakar.pujeri@dell.com/
>
> tests/overlay/081 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/overlay/081 b/tests/overlay/081
> index 2270a04..e0ab558 100755
> --- a/tests/overlay/081
> +++ b/tests/overlay/081
> @@ -14,6 +14,7 @@ _begin_fstest auto quick
> . ./common/filter
> . ./common/attr
>
> +_require_scratch
As you're fixing this patch, I'm wondering if we need a _require_* helper to
make sure the mount options *uuid=null/auto/on* is supported by current system?
Due to the comment says "mount options uuid=null/auto/on introduced in kernel
v6.6" :)
>
> _scratch_mkfs >>$seqres.full 2>&1
>
> --
> 2.55.0
>
prev parent reply other threads:[~2026-09-02 5:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 13:24 [PATCH v2] overlay/081: add missing _require_scratch check Prabhakar Pujeri
2026-09-02 5:51 ` Zorro Lang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ape4hyfwsv5LrYxB@zlang-mailbox \
--to=zlang@kernel.org \
--cc=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=prabhakar.pujeri@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox