From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=FROM_LOCAL_HEX, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A34D7C432C0 for ; Wed, 20 Nov 2019 23:37:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77815206D8 for ; Wed, 20 Nov 2019 23:37:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726014AbfKTXhD (ORCPT ); Wed, 20 Nov 2019 18:37:03 -0500 Received: from mail-il1-f200.google.com ([209.85.166.200]:35279 "EHLO mail-il1-f200.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725878AbfKTXhC (ORCPT ); Wed, 20 Nov 2019 18:37:02 -0500 Received: by mail-il1-f200.google.com with SMTP id w69so1209680ilk.2 for ; Wed, 20 Nov 2019 15:37:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:date:in-reply-to:message-id:subject :from:to; bh=Dzf4MAFardbO+bPz8t/DWqzuGgsxHOT5uI8e9FmGTKo=; b=gJBXYstcyjBHxzMI9Q4ODdEWkGgaAqVTvZrtEo5Sf78LIkVm0PX9HwZALsICMItu2j 3jO3HNjkstNPoxhFnKpctu4ABqjoB5iB5AMvwvPh/DlNtXFkxxtyTSsmRDCMIp7yjzZ1 G796sgx5FfzjzqdfQq+avlVR0PNSYCWBrxkkqUilRpx20Be9OBTMZ8S99wSW1eod06w/ RlGcCPUvGM2RhmXxPOGWmlj2Cnt4kis24XFa1NUFAohmIkgvBr5YxZzmwwlZqfwzZTw8 7qBVqerDXK6PH8/aRualjLkLu/wFn7tvCTLibi98f3gzxR6bwBoS/VbTRifl2ZKwZ6aS czrw== X-Gm-Message-State: APjAAAX45KX947dDirANmojifJju+5tI5h5ZaaeYYYcPzTRC2EdVqj68 Ym9C96o46Wj+WH5k+kaAXwthojfTVJ+BapSd+CCvF4e3cN5K X-Google-Smtp-Source: APXvYqzUGsHe/ChS3EHJKTbUiGlzs8W6jt2ovTc3Xqk8nbYzL9Z9c4Bet6wf62k7oTB8dHHmVjqdu3eCEFm4ntU19VImZhXcXdW6 MIME-Version: 1.0 X-Received: by 2002:a92:7e4a:: with SMTP id z71mr6837516ilc.141.1574293020602; Wed, 20 Nov 2019 15:37:00 -0800 (PST) Date: Wed, 20 Nov 2019 15:37:00 -0800 In-Reply-To: <1574176603.28617.25.camel@suse.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <00000000000043fac50597cfa8a0@google.com> Subject: Re: WARNING in hso_free_net_device From: syzbot To: andreyknvl@google.com, linux-usb@vger.kernel.org, oneukum@suse.com, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: WARNING in hso_free_net_device hso 6-1:0.15: Can't find BULK IN endpoint ------------[ cut here ]------------ WARNING: CPU: 1 PID: 83 at net/core/dev.c:8167 rollback_registered_many.cold+0x41/0x1bc net/core/dev.c:8167 Kernel panic - not syncing: panic_on_warn set ... CPU: 1 PID: 83 Comm: kworker/1:2 Not tainted 5.3.0-rc5-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: usb_hub_wq hub_event Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0xca/0x13e lib/dump_stack.c:113 panic+0x2a3/0x6da kernel/panic.c:219 __warn.cold+0x20/0x4a kernel/panic.c:576 report_bug+0x262/0x2a0 lib/bug.c:186 fixup_bug arch/x86/kernel/traps.c:179 [inline] fixup_bug arch/x86/kernel/traps.c:174 [inline] do_error_trap+0x12b/0x1e0 arch/x86/kernel/traps.c:272 do_invalid_op+0x32/0x40 arch/x86/kernel/traps.c:291 invalid_op+0x23/0x30 arch/x86/entry/entry_64.S:1028 RIP: 0010:rollback_registered_many.cold+0x41/0x1bc net/core/dev.c:8167 Code: ff e8 c7 26 90 fc 48 c7 c7 40 ec 63 86 e8 24 c8 7a fc 0f 0b e9 93 be ff ff e8 af 26 90 fc 48 c7 c7 40 ec 63 86 e8 0c c8 7a fc <0f> 0b 4c 89 e7 e8 f9 12 34 fd 31 ff 41 89 c4 89 c6 e8 bd 27 90 fc RSP: 0018:ffff8881d938f080 EFLAGS: 00010286 RAX: 0000000000000024 RBX: ffff8881d5ef8000 RCX: 0000000000000000 RDX: 0000000000000000 RSI: ffffffff81288cfd RDI: ffffed103b271e02 RBP: ffff8881d938f1b0 R08: 0000000000000024 R09: fffffbfff11ad794 R10: fffffbfff11ad793 R11: ffffffff88d6bc9f R12: ffff8881d5ef8070 R13: ffff8881d938f140 R14: dffffc0000000000 R15: 0000000000000000 rollback_registered+0xf2/0x1c0 net/core/dev.c:8243 unregister_netdevice_queue net/core/dev.c:9290 [inline] unregister_netdevice_queue+0x1d7/0x2b0 net/core/dev.c:9283 unregister_netdevice include/linux/netdevice.h:2631 [inline] unregister_netdev+0x18/0x20 net/core/dev.c:9331 hso_free_net_device+0x100/0x310 drivers/net/usb/hso.c:2366 hso_create_net_device+0x772/0x9c0 drivers/net/usb/hso.c:2554 hso_probe+0x28d/0x1a46 drivers/net/usb/hso.c:2931 usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361 really_probe+0x281/0x6d0 drivers/base/dd.c:548 driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454 __device_attach+0x217/0x360 drivers/base/dd.c:894 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514 device_add+0xae6/0x16f0 drivers/base/core.c:2165 usb_set_configuration+0xdf6/0x1670 drivers/usb/core/message.c:2023 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210 usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266 really_probe+0x281/0x6d0 drivers/base/dd.c:548 driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454 __device_attach+0x217/0x360 drivers/base/dd.c:894 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514 device_add+0xae6/0x16f0 drivers/base/core.c:2165 usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2536 hub_port_connect drivers/usb/core/hub.c:5098 [inline] hub_port_connect_change drivers/usb/core/hub.c:5213 [inline] port_event drivers/usb/core/hub.c:5359 [inline] hub_event+0x1b5c/0x3640 drivers/usb/core/hub.c:5441 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269 worker_thread+0x96/0xe20 kernel/workqueue.c:2415 kthread+0x318/0x420 kernel/kthread.c:255 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 Kernel Offset: disabled Rebooting in 86400 seconds.. Tested on: commit: eea39f24 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git console output: https://syzkaller.appspot.com/x/log.txt?x=16dea1cee00000 kernel config: https://syzkaller.appspot.com/x/.config?x=d0c62209eedfd54e dashboard link: https://syzkaller.appspot.com/bug?extid=44d53c7255bb1aea22d2 compiler: gcc (GCC) 9.0.0 20181231 (experimental) patch: https://syzkaller.appspot.com/x/patch.diff?x=11bc631ce00000