From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,FROM_LOCAL_HEX, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BC60C433DB for ; Thu, 31 Dec 2020 01:54:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05AC121973 for ; Thu, 31 Dec 2020 01:54:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726504AbgLaByf (ORCPT ); Wed, 30 Dec 2020 20:54:35 -0500 Received: from mail-io1-f71.google.com ([209.85.166.71]:54371 "EHLO mail-io1-f71.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726499AbgLaByf (ORCPT ); Wed, 30 Dec 2020 20:54:35 -0500 Received: by mail-io1-f71.google.com with SMTP id w26so7752481iox.21 for ; Wed, 30 Dec 2020 17:54:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:date:in-reply-to:message-id:subject :from:to:cc; bh=FdZTn6oLt2h1f5MhJVFstju7o/Z0EftaGAcqBWG7ncY=; b=MRdG1Fo077Gk9AbaFKX0fkllUUrzzOTgTkr+j6GoS9BegcHZXTuzyRI8GF8/y2wzKb 4z0UT4yn8raUUvDuNln3uSClURt7oRSSbGMg6XXzTmz2yBelgVu1JpsmGoNl5vdImjDJ VJ99v3Q2sdHft0dXAkl35kRuFTjeols5Mbwpp0pCaC/n6CUVxjQVwolJGyvJ4oh0vswG 8y4oAFrfiMXI//tGSVhuJfkX8kjyUj987jQNIFSj6fCsctjuvr1H4xJ0g4qqpmBKHgOW oUzH8S+sRd7BEcMXKt0J0Guj8wvA6wPT+dCHkdGR0n3xWZrAmJ4fwSWkXFTN1dSrPKqJ si8g== X-Gm-Message-State: AOAM530ZSokOe+5Mo8wD4Id0CkUdw7PkpmitW0OdMmYnQzd2DGnjY0m3 q3N/sNzp5ugDELbG/4xe6EZ5UN940ivKq3VBvsTVCXBT9w4G X-Google-Smtp-Source: ABdhPJy/+c5PxXndhI52KzY/wHMyn6U0qATIbhO7SwFEiBz9oJu3s57OASzyLH4AS5ZUKKQmR2T508uqUp4ZAhFV60iXvdn/Y0c4 MIME-Version: 1.0 X-Received: by 2002:a92:bb84:: with SMTP id x4mr54012722ilk.298.1609379634982; Wed, 30 Dec 2020 17:53:54 -0800 (PST) Date: Wed, 30 Dec 2020 17:53:54 -0800 In-Reply-To: X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <00000000000073b51105b7b8e52d@google.com> Subject: Re: Re: [RFT][PATCH v1] media: zr364xx: Fix memory leak in ->probe() From: syzbot To: Ezequiel Garcia Cc: andriy.shevchenko@linux.intel.com, ezequiel@vanguardiasur.com.ar, linux-media@vger.kernel.org, linux-usb@vger.kernel.org, mchehab@kernel.org, royale@zerezo.com, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org > Hey Andy, > > Thank you for the patch. > > On Wed, 30 Dec 2020 at 18:22, Andy Shevchenko > wrote: >> >> When ->probe() fails in some cases it may not free resources. >> Replace few separated calls by v4l2_device_put() to clean up >> everything. >> >> Reported-by: syzbot+b4d54814b339b5c6bbd4@syzkaller.appspotmail.com >> Signed-off-by: Andy Shevchenko >> --- >> I have no hardware and hadn't done any test of this. >> > > For bugs with reproducers such as this one, syzbot will test your > patches really quickly. > Just push the patch somewhere and then reply to syzbot bug report mail with > > #syz test: git://repo/address.git commit-hash "git://repo/address.git" does not look like a valid git repo address. > > You can experiment with syzbot by replying only to syzbot's mail address. > > See https://github.com/google/syzkaller/blob/master/docs/syzbot.md#testing-patches > for more details. > > Cheers, > Ezequiel > > >> drivers/media/usb/zr364xx/zr364xx.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/media/usb/zr364xx/zr364xx.c b/drivers/media/usb/zr364xx/zr364xx.c >> index 1e1c6b4d1874..5b9e31af57cf 100644 >> --- a/drivers/media/usb/zr364xx/zr364xx.c >> +++ b/drivers/media/usb/zr364xx/zr364xx.c >> @@ -1533,9 +1533,7 @@ static int zr364xx_probe(struct usb_interface *intf, >> return 0; >> >> fail: >> - v4l2_ctrl_handler_free(hdl); >> - v4l2_device_unregister(&cam->v4l2_dev); >> - kfree(cam); >> + v4l2_device_put(&cam->v4l2_dev); >> return err; >> } >> >> -- >> 2.29.2 >>