From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=FROM_LOCAL_HEX, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E673C3A5A5 for ; Tue, 3 Sep 2019 19:58:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 156BF230F2 for ; Tue, 3 Sep 2019 19:58:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726858AbfICT6C (ORCPT ); Tue, 3 Sep 2019 15:58:02 -0400 Received: from mail-io1-f71.google.com ([209.85.166.71]:44623 "EHLO mail-io1-f71.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726063AbfICT6C (ORCPT ); Tue, 3 Sep 2019 15:58:02 -0400 Received: by mail-io1-f71.google.com with SMTP id f5so24424260ioo.11 for ; Tue, 03 Sep 2019 12:58:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:date:in-reply-to:message-id:subject :from:to; bh=YZFkFqSBZlXCsTX8H4h5Yth49X7XJVAXMqwtv9OLsbo=; b=FiLAYiApZ5DepsC2gH5BRlWCG4dnmlx3BZL53ck7T2Sr6nXJx/8vBiFm0fbHLaUwbu ZP6/Ggn2lgMf1pXEZN1BcnLJwzvImEefM8kd5MAalpK/kCbLL1WM1//9py5MAzPjqWNm NcHsWoCsUjINLKaGkbewIpSfmgZqhLUF+yVspxgylLhRym+yN/Izb1fd/xXObLdCiEew PFaZRFKUKvsjncl+dmfLrMfjGyASOMQXhn+hkVmLVpoqbxvGmmCqKlVscqmqXf6BegTB GwNjGI9wS1v193k5GplmZP/lSRCd/RFOzFfosVcvzPLvUcmoO258+NQH+Ih2l+TKCLwb o58Q== X-Gm-Message-State: APjAAAWF/T1PnbBYgZETV9lc4EGAjKvDvliUn3HmzU4rfdwbodSj6dSf uLRo5HaMTSTgn+4N0Mv+Ddn5Ca5PLR16lWV/SVudLrvUHAtP X-Google-Smtp-Source: APXvYqyywYUJ6VNb/rKVpCUCMQ5UuchpDQ9BuiRuqmd+HWjehyHYh2InOTSia273i4pr9JRlD5i/mxNTbkQpXook7z6JLmWD/EMu MIME-Version: 1.0 X-Received: by 2002:a5e:de0a:: with SMTP id e10mr24600615iok.46.1567540681380; Tue, 03 Sep 2019 12:58:01 -0700 (PDT) Date: Tue, 03 Sep 2019 12:58:01 -0700 In-Reply-To: X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <0000000000007c1f820591ab8105@google.com> Subject: Re: KASAN: slab-out-of-bounds Read in usb_reset_and_verify_device From: syzbot To: Thinh.Nguyen@synopsys.com, andreyknvl@google.com, dianders@chromium.org, gregkh@linuxfoundation.org, jflat@chromium.org, kai.heng.feng@canonical.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, malat@debian.org, mathias.nyman@linux.intel.com, nsaenzjulienne@suse.de, stern@rowland.harvard.edu, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: KASAN: slab-out-of-bounds Read in usb_reset_and_verify_device usb 4-1: Using ep0 maxpacket: 16 usb 4-1: Old BOS ffff8881d516b780 Len 0xa8 usb 4-1: New BOS ffff8881d5dd6d20 Len 0xa8 ================================================================== BUG: KASAN: slab-out-of-bounds in memcmp+0xa6/0xb0 lib/string.c:904 Read of size 1 at addr ffff8881d5dd6db6 by task kworker/0:1/12 CPU: 0 PID: 12 Comm: kworker/0:1 Not tainted 5.3.0-rc5+ #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: usb_hub_wq hub_event Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0xca/0x13e lib/dump_stack.c:113 print_address_description+0x6a/0x32c mm/kasan/report.c:351 __kasan_report.cold+0x1a/0x33 mm/kasan/report.c:482 kasan_report+0xe/0x12 mm/kasan/common.c:612 memcmp+0xa6/0xb0 lib/string.c:904 memcmp include/linux/string.h:400 [inline] descriptors_changed drivers/usb/core/hub.c:5579 [inline] usb_reset_and_verify_device+0x5a8/0x1350 drivers/usb/core/hub.c:5736 usb_reset_device+0x4c1/0x920 drivers/usb/core/hub.c:5905 rt2x00usb_probe+0x53/0x7af drivers/net/wireless/ralink/rt2x00/rt2x00usb.c:806 usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361 really_probe+0x281/0x6d0 drivers/base/dd.c:548 driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454 __device_attach+0x217/0x360 drivers/base/dd.c:894 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514 device_add+0xae6/0x16f0 drivers/base/core.c:2165 usb_set_configuration+0xdf6/0x1670 drivers/usb/core/message.c:2023 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210 usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266 really_probe+0x281/0x6d0 drivers/base/dd.c:548 driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454 __device_attach+0x217/0x360 drivers/base/dd.c:894 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514 device_add+0xae6/0x16f0 drivers/base/core.c:2165 usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2536 hub_port_connect drivers/usb/core/hub.c:5098 [inline] hub_port_connect_change drivers/usb/core/hub.c:5213 [inline] port_event drivers/usb/core/hub.c:5359 [inline] hub_event+0x1b5c/0x3640 drivers/usb/core/hub.c:5441 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269 worker_thread+0x96/0xe20 kernel/workqueue.c:2415 kthread+0x318/0x420 kernel/kthread.c:255 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 Allocated by task 12: save_stack+0x1b/0x80 mm/kasan/common.c:69 set_track mm/kasan/common.c:77 [inline] __kasan_kmalloc mm/kasan/common.c:487 [inline] __kasan_kmalloc.constprop.0+0xbf/0xd0 mm/kasan/common.c:460 kmalloc include/linux/slab.h:557 [inline] kzalloc include/linux/slab.h:748 [inline] usb_get_bos_descriptor+0x1fd/0x8f2 drivers/usb/core/config.c:955 hub_port_init+0x169a/0x2d30 drivers/usb/core/hub.c:4837 usb_reset_and_verify_device+0x3aa/0x1350 drivers/usb/core/hub.c:5720 usb_reset_device+0x4c1/0x920 drivers/usb/core/hub.c:5905 rt2x00usb_probe+0x53/0x7af drivers/net/wireless/ralink/rt2x00/rt2x00usb.c:806 usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361 really_probe+0x281/0x6d0 drivers/base/dd.c:548 driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454 __device_attach+0x217/0x360 drivers/base/dd.c:894 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514 device_add+0xae6/0x16f0 drivers/base/core.c:2165 usb_set_configuration+0xdf6/0x1670 drivers/usb/core/message.c:2023 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210 usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266 really_probe+0x281/0x6d0 drivers/base/dd.c:548 driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454 __device_attach+0x217/0x360 drivers/base/dd.c:894 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514 device_add+0xae6/0x16f0 drivers/base/core.c:2165 usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2536 hub_port_connect drivers/usb/core/hub.c:5098 [inline] hub_port_connect_change drivers/usb/core/hub.c:5213 [inline] port_event drivers/usb/core/hub.c:5359 [inline] hub_event+0x1b5c/0x3640 drivers/usb/core/hub.c:5441 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269 worker_thread+0x96/0xe20 kernel/workqueue.c:2415 kthread+0x318/0x420 kernel/kthread.c:255 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 Freed by task 0: (stack is not available) The buggy address belongs to the object at ffff8881d5dd6d80 which belongs to the cache kmalloc-64 of size 64 The buggy address is located 54 bytes inside of 64-byte region [ffff8881d5dd6d80, ffff8881d5dd6dc0) The buggy address belongs to the page: page:ffffea0007577580 refcount:1 mapcount:0 mapping:ffff8881da003180 index:0x0 flags: 0x200000000000200(slab) raw: 0200000000000200 dead000000000100 dead000000000122 ffff8881da003180 raw: 0000000000000000 00000000802a002a 00000001ffffffff 0000000000000000 page dumped because: kasan: bad access detected Memory state around the buggy address: ffff8881d5dd6c80: fb fb fb fb fc fc fc fc fb fb fb fb fb fb fb fb ffff8881d5dd6d00: fc fc fc fc 00 00 00 00 00 00 fc fc fc fc fc fc > ffff8881d5dd6d80: 00 00 00 00 00 00 06 fc fc fc fc fc fc fc fc fc ^ ffff8881d5dd6e00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ffff8881d5dd6e80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ================================================================== Tested on: commit: eea39f24 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git console output: https://syzkaller.appspot.com/x/log.txt?x=11366b8e600000 kernel config: https://syzkaller.appspot.com/x/.config?x=d0c62209eedfd54e dashboard link: https://syzkaller.appspot.com/bug?extid=35f4d916c623118d576e compiler: gcc (GCC) 9.0.0 20181231 (experimental) patch: https://syzkaller.appspot.com/x/patch.diff?x=1740de51600000