linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] usb: misc: Add x86 dependency for Intel USBIO driver
@ 2025-10-06 21:39 Peter Robinson
  2025-10-07  9:59 ` Hans de Goede
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Robinson @ 2025-10-06 21:39 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Israel Cepeda, Hans de Goede, linux-usb
  Cc: Peter Robinson

The Intel USBIO driver is x86 only, other architectures have ACPI
so add an appropriate depenecy plus compile test.

Fixes: 121a0f839dbb3 ("usb: misc: Add Intel USBIO bridge driver")
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 drivers/usb/misc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig
index 09ac6f1c985fd..0b56b773dbdf7 100644
--- a/drivers/usb/misc/Kconfig
+++ b/drivers/usb/misc/Kconfig
@@ -182,6 +182,7 @@ config USB_LJCA
 config USB_USBIO
 	tristate "Intel USBIO Bridge support"
 	depends on USB && ACPI
+	depends on X86 || COMPILE_TEST
 	select AUXILIARY_BUS
 	help
 	  This adds support for Intel USBIO drivers.
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] usb: misc: Add x86 dependency for Intel USBIO driver
  2025-10-06 21:39 [PATCH] usb: misc: Add x86 dependency for Intel USBIO driver Peter Robinson
@ 2025-10-07  9:59 ` Hans de Goede
  2025-10-09  1:45   ` Cepeda Lopez, Israel A
  0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2025-10-07  9:59 UTC (permalink / raw)
  To: Peter Robinson, Greg Kroah-Hartman, Israel Cepeda, linux-usb

Hi,

On 6-Oct-25 11:39 PM, Peter Robinson wrote:
> The Intel USBIO driver is x86 only, other architectures have ACPI
> so add an appropriate depenecy plus compile test.
> 
> Fixes: 121a0f839dbb3 ("usb: misc: Add Intel USBIO bridge driver")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Technically the chip could also be used on other platforms,
but yes in practice it is only used on x86 platforms so
no objections from me:

Reviewed-by: Hans de Goede <hansg@kernel.org>

Regards,

Hans



> ---
>  drivers/usb/misc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig
> index 09ac6f1c985fd..0b56b773dbdf7 100644
> --- a/drivers/usb/misc/Kconfig
> +++ b/drivers/usb/misc/Kconfig
> @@ -182,6 +182,7 @@ config USB_LJCA
>  config USB_USBIO
>  	tristate "Intel USBIO Bridge support"
>  	depends on USB && ACPI
> +	depends on X86 || COMPILE_TEST
>  	select AUXILIARY_BUS
>  	help
>  	  This adds support for Intel USBIO drivers.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] usb: misc: Add x86 dependency for Intel USBIO driver
  2025-10-07  9:59 ` Hans de Goede
@ 2025-10-09  1:45   ` Cepeda Lopez, Israel A
  0 siblings, 0 replies; 3+ messages in thread
From: Cepeda Lopez, Israel A @ 2025-10-09  1:45 UTC (permalink / raw)
  To: Hans de Goede, Peter Robinson, Greg Kroah-Hartman,
	linux-usb@vger.kernel.org

Make sense to me, no objections either.

> -----Original Message-----
> From: Hans de Goede <hansg@kernel.org>
> Sent: Tuesday, October 7, 2025 2:59 AM
> To: Peter Robinson <pbrobinson@gmail.com>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>; Cepeda Lopez, Israel A
> <israel.a.cepeda.lopez@intel.com>; linux-usb@vger.kernel.org
> Subject: Re: [PATCH] usb: misc: Add x86 dependency for Intel USBIO driver
> 
> Hi,
> 
> On 6-Oct-25 11:39 PM, Peter Robinson wrote:
> > The Intel USBIO driver is x86 only, other architectures have ACPI
> > so add an appropriate depenecy plus compile test.
> >
> > Fixes: 121a0f839dbb3 ("usb: misc: Add Intel USBIO bridge driver")
> > Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> 
> Technically the chip could also be used on other platforms,
> but yes in practice it is only used on x86 platforms so
> no objections from me:
> 
> Reviewed-by: Hans de Goede <hansg@kernel.org>
> 
> Regards,
> 
> Hans
> 
> 
> 
> > ---
> >  drivers/usb/misc/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig
> > index 09ac6f1c985fd..0b56b773dbdf7 100644
> > --- a/drivers/usb/misc/Kconfig
> > +++ b/drivers/usb/misc/Kconfig
> > @@ -182,6 +182,7 @@ config USB_LJCA
> >  config USB_USBIO
> >  	tristate "Intel USBIO Bridge support"
> >  	depends on USB && ACPI
> > +	depends on X86 || COMPILE_TEST
> >  	select AUXILIARY_BUS
> >  	help
> >  	  This adds support for Intel USBIO drivers.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-10-09  1:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-06 21:39 [PATCH] usb: misc: Add x86 dependency for Intel USBIO driver Peter Robinson
2025-10-07  9:59 ` Hans de Goede
2025-10-09  1:45   ` Cepeda Lopez, Israel A

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).