From: Shuah Khan <skhan@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Valentina Manea <valentina.manea.m@gmail.com>,
Shuah Khan <shuah@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] usbip: Use fallthrough pseudo-keyword
Date: Wed, 8 Jul 2020 10:39:22 -0600 [thread overview]
Message-ID: <0459d720-b2f5-c604-9356-c022fa3d37c8@linuxfoundation.org> (raw)
In-Reply-To: <dd532813cc28b6f27b2d0ed6bd3529f2@perches.com>
On 7/8/20 9:39 AM, Joe Perches wrote:
> On 2020-07-08 07:35, Shuah Khan wrote:
>> On 7/7/20 7:56 PM, Joe Perches wrote:
>>> On Tue, 2020-07-07 at 14:06 -0600, Shuah Khan wrote:
>>>> On 7/7/20 1:52 PM, Gustavo A. R. Silva wrote:
>>>>> Replace the existing /* fall through */ comments and its variants with
>>>>> the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
>>>>> fall-through markings when it is the case.
>>>>>
>>>>> [1]
>>>>> https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>>>>>
>>>>>
>>>>
>>>> Is fallthrough syntax supported on our min gcc version?
>>>
>>> No. Introduced in gcc 7.
>>>
>>
>> Gustavo,
>>
>> In which case, this patch would break usbip build on older gcc
>> revisions.
>
> No it will not. Comment fall through was introduced in gcc 7 and this
> devolved into a do while 0
Ah thanks. I didn't know that. No concerns of patch to go in.
thanks,
--- Shuah
next prev parent reply other threads:[~2020-07-08 16:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 19:52 [PATCH] usbip: Use fallthrough pseudo-keyword Gustavo A. R. Silva
2020-07-07 20:06 ` Shuah Khan
2020-07-08 1:56 ` Joe Perches
2020-07-08 10:16 ` Julia Lawall
2020-07-08 14:42 ` Shuah Khan
2020-07-08 14:35 ` Shuah Khan
2020-07-08 15:39 ` Joe Perches
2020-07-08 16:39 ` Shuah Khan [this message]
2020-07-08 18:11 ` Gustavo A. R. Silva
-- strict thread matches above, loose matches on Subject: below --
2024-02-15 9:26 [PATCH] USBIP: " Pairman Guo
2024-02-15 10:14 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0459d720-b2f5-c604-9356-c022fa3d37c8@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).