From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D91CCC77B7C for ; Thu, 11 May 2023 12:16:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237866AbjEKMQp (ORCPT ); Thu, 11 May 2023 08:16:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237804AbjEKMQn (ORCPT ); Thu, 11 May 2023 08:16:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA2F24C33; Thu, 11 May 2023 05:16:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A84D964C94; Thu, 11 May 2023 12:16:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99441C433D2; Thu, 11 May 2023 12:16:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683807379; bh=V2loH3pu0Avgj+Vg+y+wMUSNmoAWUOeZAfZNv5xIAVA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CNfajOGejkFrHxHupuuuOLpzWMxwuWoJprhby9j+hxsK+rIUjs2k12F4pTjO9RIfE 06LET49WAngjBnPz7o1u58OOu+Xya5bOzTdE5rL0krN2DIHqYxhUp74ML+kmiYowg8 vvh8GXvbuXjgGLXUKWKmpwKOzzG3OSxUUEHhK2qqsCAfb2YFAeFfAV7gB6tkm7qNgx BmCMWCtb6nwThekV7ojhGoQn+oKRyS1yI5g4qWkl7ZvhQL1Rgpp9louIE011s/HJMf IayTu5gYiruDIu0UnQTt3jyzDGFSMfFR2VQvWIujEKHPII2XOf4S8e92xYETaN4+Gz 9reZYZjnbZSaQ== Message-ID: <05057f6d-cb38-8e4a-5d30-82863e0cda44@kernel.org> Date: Thu, 11 May 2023 15:16:14 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 1/2] dt-bindings: cdns,usb3: Add clock and reset Content-Language: en-US To: Krzysztof Kozlowski , Minda Chen , Rob Herring , Krzysztof Kozlowski , Pawel Laszczak , Greg Kroah-Hartman , Peter Chen , Philipp Zabel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <20230510132816.108820-1-minda.chen@starfivetech.com> <20230510132816.108820-2-minda.chen@starfivetech.com> <9cf5965a-8290-dfff-9f92-07ed2df66650@linaro.org> From: Roger Quadros In-Reply-To: <9cf5965a-8290-dfff-9f92-07ed2df66650@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 11/05/2023 12:26, Krzysztof Kozlowski wrote: > On 10/05/2023 15:28, Minda Chen wrote: >> To support generic clock and reset init in Cadence USBSS >> controller, add clock and reset dts configuration. >> >> Signed-off-by: Minda Chen >> --- >> .../devicetree/bindings/usb/cdns,usb3.yaml | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >> index cae46c4982ad..623c6b34dee3 100644 >> --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >> +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >> @@ -42,6 +42,18 @@ properties: >> - const: otg >> - const: wakeup >> >> + clocks: >> + minItems: 1 >> + maxItems: 8 >> + description: >> + USB controller clocks. > > You need to list the items. And why is it variable? Your clock choice in > the example is poor, I doubt it is real. > >> + >> + resets: >> + minItems: 1 >> + maxItems: 8 >> + description: >> + USB controller generic resets. > > Here as well. > > You had one clock last time, thus the review was - drop the names. Now > you changed it to 8 clocks... I don't understand. > Different platforms may have different number of clocks/resets or none. So I don't think minItems/maxItems should be specified. -- cheers, -roger