Linux USB
 help / color / mirror / Atom feed
From: Hayes Wang <hayeswang@realtek.com>
To: Linmao Li <lilinmao@kylinos.cn>, Andrew Lunn <andrew@lunn.ch>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Chih Kai Hsu <hsu.chih.kai@realtek.com>,
	nic_swsd <nic_swsd@realtek.com>,
	Birger Koblitz <mail@birger-koblitz.de>,
	Xiangqian Zhang <zhangxiangqian@kylinos.cn>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH net v2] r8152: Use BMSR to detect the link state
Date: Tue, 13 Oct 2026 10:30:32 +0000	[thread overview]
Message-ID: <0573f6c64cac4bdd83388cb1bd76583a@realtek.com> (raw)
In-Reply-To: <c32ac5e1-ecbe-4857-b36f-cd0cb1f54f90@kylinos.cn>

Linmao Li <lilinmao@kylinos.cn>
> Sent: Tuesday, October 13, 2026 10:36 AM
[...]
> Hi Andrew,
> 
> Thanks. In tests on my RTL8153B, down and up notifications were about
> 3.1 s apart after a quick cable replug, and about 3.4 s apart after ethtool -r. A
> double read should still report down if the link work runs during that interval,
> but I have not verified this directly.
> These results do not cover shorter link interruptions or other chips.
> 
> Since this fixes a regression for net and stable, would you accept a) there,
> keeping PLA_PHYSTATUS and reading BMSR once before an off-to-on carrier
> transition, and moving carrier detection to BMSR with per-chip handling as a
> follow-up for net-next, once the chip behaviour is known?
> 
> Hayes, to build that list: which ICs notify only on link changes? And on any of
> them, does reading BMSR, which clears the latched link down, trigger another
> notification? The single read depends on that. Birger tested v2 on an RTL8157
> and an RTL8153A without problems, so it would also help to know how the
> RTL8157 notifies.

Some users have complained about the periodic notifications, so we plan to modify the driver accordingly.
RTL8156 and later chips will notify the driver only when the link state changes. 
The Windows driver already uses this behavior.
In addition, I don’t believe that clearing the latched link-down status will trigger another notification.


Best Regards,
Hayes


  reply	other threads:[~2026-10-13 10:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 10:52 [PATCH net v2] r8152: Use BMSR to detect the link state Linmao Li
2026-10-05 18:32 ` Birger Koblitz
2026-10-09  7:18   ` Linmao Li
2026-10-12 16:13     ` Birger Koblitz
2026-10-13  2:38       ` Linmao Li
2026-10-13  3:51         ` Birger Koblitz
2026-10-06  8:28 ` Hayes Wang
2026-10-06 16:10   ` Andrew Lunn
2026-10-09  7:16     ` Linmao Li
2026-10-09 12:22       ` Andrew Lunn
2026-10-13  2:36         ` Linmao Li
2026-10-13 10:30           ` Hayes Wang [this message]
2026-10-13  8:04         ` Hayes Wang
2026-10-13  7:37       ` Hayes Wang
2026-10-06 22:55 ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0573f6c64cac4bdd83388cb1bd76583a@realtek.com \
    --to=hayeswang@realtek.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=hsu.chih.kai@realtek.com \
    --cc=kuba@kernel.org \
    --cc=lilinmao@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mail@birger-koblitz.de \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=zhangxiangqian@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox