From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 798D84ACC97 for ; Wed, 2 Sep 2026 16:59:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788368354; cv=none; b=TG+X7hyg4X5rFfD96GdBYy/MbqNhzwfqIkisbFsJr8O9WJ5hweOAWSgiSVVW1iUHHn3BxhHEgVMAlGe5x22TqDbGLeWLHSRX7rln0MgrRqNRRXPSV+Btpie3QMOE8e2vOyOquI0ORtIO4tmYgVkAomcDeWGnxsEU8X1Gwm3K99w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788368354; c=relaxed/simple; bh=MzkVNcbwJx3DdBFKW/Eg+IrelBGsrxW6GRwxoH136Ls=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kds3Tf3KdpbomYqBzwoJDhcGAdBS2v2ltS4YPHvBRao3acA1rxulSFM1l23JI2fDAdCAFKhTi5uvxNCdMmZUuujWFyLI+yTpWesMqpH+D8cKwHvnqjZjQ6U8AI2F/8ZA/KM3cmDQS/xxHEG4CAW5ZTH8cgHMgIPeIiC/I37vr4w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CblRizxD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QTLlmaVu; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CblRizxD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QTLlmaVu" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 682GflQX2572294 for ; Wed, 2 Sep 2026 16:59:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4VWeAjn1O5Hn8350LhDD1vBbMv3y8ytANZiqJ99qoeM=; b=CblRizxDKb9FG0XW H11mWHUVzpftvuGmRF39QBJF9RoVPXqKi+xTjlvAA/BcZ/hWjth8MqfUMd8CxbvG wS0PSsKXRbixISZwJJ1Gf7Hb3P5glHzcM7QyiqbweX/kLVhb0BFIv6UC+tv+hNkr +dn5lVh4uWZLcrkAiPj4oA43UEEiayPi9LDgXF8cyOSqcSUhVOBJtGsMpMU2ab5z GXOBkzWzkgE0Oq0x+r+Yx3tfUgeXr2B9LxzGPIZl0NK6+f43BIS+wmSVWiZIqvPy dPzPzmHQggO5mc8uKyWmait3j2ytp1iNHEbvFo7pNzy7jQQ3jWKoPX3vU0PoF0xj 0JXX8g== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4geguy1wt2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 02 Sep 2026 16:59:11 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-398d292eac1so2644407a91.1 for ; Wed, 02 Sep 2026 09:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788368350; x=1788973150; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4VWeAjn1O5Hn8350LhDD1vBbMv3y8ytANZiqJ99qoeM=; b=QTLlmaVuCOpMYQSkPZfm3MifvPdI8nlNOlPXZT5Yex2sTN4FY9Gs4xTC9sq1MMtZnq f2tKu08kr3SGXImCSMaat1NDsv9ELiFpxTWQZk51NgAJALQJ5Kt8n7yrolGDsd2RZ3Ne RvigTpzs9Zfj1lLo2TaV8b+ITK682kFw1Z5dxS0erPAvbVH8N1OCwkqsSPJxor5KX7WQ 8IQkwekJAhgcNrSHNfZZ3kbSBVvFR8fs2xmH4FqaLgEanULLOrxuc+sy/WQLTHX9O01X 1Ibizy+v4zV0C3i1razkZpocJS/0ns//KMYnbB59cE0+94w5zpMzurlrTh3cZpTngKxt 99Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788368350; x=1788973150; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4VWeAjn1O5Hn8350LhDD1vBbMv3y8ytANZiqJ99qoeM=; b=IiMaiPTa4rSOPTuOl/9ecGdmLQf/VdKLVPeJu2F7jlIaoI3+36yeVrq38PDFwfmv5m 9KKnz5UaljJd22i3BV939eV1mHFTgaj5WZDbBXG0Awf++KesVYZ+OeGIklZh1oATYcfy G8lHLiZ+CoCAqlemEdMIqmTA+enGtUrT9lkPx/wRUgItoxMZTGr2WyWQkcXx+5JYQTS3 sBkItB57h8FsrH7JTKM9TxfNPxPQRIUPi7uJ1O5c6iEeCi6O10N5AhWmOeCjpwPLgWqN IDJ33MdoF2ExFW/EehryQ8bshgQyY7UunMF+nXCRUG+7tbn2g2862qVUfpDBDKFxgLXQ /U7A== X-Forwarded-Encrypted: i=1; AKwUvBxAVU2pAqdDnKdDYn2vP9+4kxYE+VRPaHrFJ862eAmURnC2rOSTRP7Q+eVzyzB8EzREw2BV0kYkq9c=@vger.kernel.org X-Gm-Message-State: AFuF++nzIC8AtwRVz1ZSn02gpvhQkRMzBnJ/YD5issOs8Sp+XwnwpO4V AlWs30U/w6CwM8U4UJB8M2u+aFiptDCYehOefg2pLVasorGlUFTwN/nNEX/n8cZ8bQ+8opC3HAp 8oFapiNWMmiWvtK2Cs9bHQGd7Enf4XltEnk5wD57YgjXHo5qVb7Qzt96obb8WUaU= X-Gm-Gg: AYBFou2cf1j/IugsOTi8wqWf0r1CRjJS/3r/3mmJuTxyw4dgfO39uz0wVZ5t4VOL01M t+GvyDNJmydfoGjYHqfrBZsCe3r8APQB+/zcYPrko47HXscXeOVY3UKGP/5nxDwX4cVmGj2lOvo COp2KS4bqioPehtIuFwjSFFD1KkDacHoyRZjZNFX1Ygh72oVnsK77TieV+ymy5ECfDmU3t0lEvi Zny/XKiR/GLOZkGQq5OskDmZlhbDwgwtMN4xneKvXPgv4T8LHMFl1r3+jAuANI6N+7SzUFzkDIo oebUgDza2mTaoS9rU6UmfkumSQ5XygT58Bnqw98/W0TQuRuW7VL1ojvHbdoGqE8O/U/YdfkzN2f lvv+60gk4i2Ge/XRIyLlnfMeZ9riAFqfp0XtZ//d5ohl3TVx4Wop41tF/ZAfuNypJwP5U X-Received: by 2002:a17:90b:2750:b0:398:e73e:5a0c with SMTP id 98e67ed59e1d1-39aedf5d887mr9659884a91.1.1788368350214; Wed, 02 Sep 2026 09:59:10 -0700 (PDT) X-Received: by 2002:a17:90b:2750:b0:398:e73e:5a0c with SMTP id 98e67ed59e1d1-39aedf5d887mr9659802a91.1.1788368349630; Wed, 02 Sep 2026 09:59:09 -0700 (PDT) Received: from [192.168.1.5] ([122.177.240.248]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08d0d845sm276064a91.17.2026.09.02.09.59.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Sep 2026 09:59:09 -0700 (PDT) Message-ID: <06bce1c2-8498-4988-b5c0-ab42bfba86cb@oss.qualcomm.com> Date: Wed, 2 Sep 2026 22:29:02 +0530 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers To: Konrad Dybcio , Krzysztof Kozlowski Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260828081542.52796-1-krishna.kurapati@oss.qualcomm.com> <20260831-messy-ebony-warthog-cfd727@quoll> <6af2e860-ba7a-4f86-a0e7-872a312b47e4@oss.qualcomm.com> Content-Language: en-US From: Krishna Kurapati In-Reply-To: <6af2e860-ba7a-4f86-a0e7-872a312b47e4@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=UZthjqSN c=1 sm=1 tr=0 ts=6a9855df cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=2sMs7eQfJahgYk7ien9XMw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=K0I1-hzHb6ZjckI3NYUA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: v5KE33K2Cp_2hNyQJLo6w1KX6DfsrU1x X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAyMDE0OSBTYWx0ZWRfX3o0eYgSyBttj BX3h0m5nc/1G2i6rGEPHNBt8nuFTTSutcXj+PaG9mA5r9A/uD7zvyCS9zehl1my1LazLluB+4A2 GApMABk6mQMm1okH5V4Zud0T+MeASqk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAyMDE0OSBTYWx0ZWRfX4+aetNNv4mol kiy/0a0B59rFjZNJPOiMAWFXwQS0mH7WfZDrFObYkX3Mke4Z3HxkLtM4GhNaQ9lBs5QTsfwN6Qz +yREDu4V08j+KwNWvGFslxjZ8jihgKdIJ8XOdv0NdoLtF2xN9jXdOHwp+02skNs2/T1YBEKpE7c wmkWnXG9cNSvW2V7RMYE12Kx6I2HnQk1KQx+n7vQZ0rubps4vcDJY6w9LpGeWywIHvonDKBhS4A 6zUBMS2hEGjXQL+aTW/hXiXYLtJL9Fr2ikKEvT0pG1D0elb5rFLx4uzbl15mWehUZw1wxGv9owa oPaQbTzFlEex4UjJhGaF6gLtCPKGU7aCqCQufafME16BVJbtHKGZ4ut/wCdAoAlT8zFISaEReff X2VQ9dQlArcHLkcTP63CHgdcvQlQ4M7pru3IODZJrS7xfbU6hBJnS3cjJCb9u8wU8KSujORTo78 V8imne5ycLgNLQ1mvmA== X-Proofpoint-ORIG-GUID: v5KE33K2Cp_2hNyQJLo6w1KX6DfsrU1x X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-02_04,2026-09-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 impostorscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609020149 On 9/2/2026 7:40 PM, Konrad Dybcio wrote: > On 8/31/26 2:29 PM, Krzysztof Kozlowski wrote: >> On 31/08/2026 11:03, Krishna Kurapati wrote: >>> >>> >>> On 8/31/2026 2:07 PM, Krzysztof Kozlowski wrote: >>>> On Fri, Aug 28, 2026 at 01:45:42PM +0530, Krishna Kurapati wrote: >>>>> Currently for Glymur non-multiport USB controllers, number of interrupts >>>>> are limited to a maximum of "5". Either hs_phy_irq or ss_phy_irq are to be >>>>> present. > > [...] > >>>>> - qcom,eliza-dwc3 >>>>> + - qcom,glymur-dwc3 >>>>> - qcom,ipq4019-dwc3 >>>>> - qcom,ipq8064-dwc3 >>>>> - qcom,kaanapali-dwc3 >>>> >>>> This changes the ABI without an explanation. >>>> >>> As per the harware specification, the controllers do have both >>> hs_phy_irq and ss_phy_irq. Hence wanted the binding to capture that >>> info. Will update the commit message accordingly. >>> >> >> So the change in 99df63d20dabda8d7ae01bcca7cdb1e92110a555 was >> incomplete? Lack of context here is not helping. >> >> If they have these IRQs but it does not matter, then it is not a good >> reason to change ABI and you should just add the clock as optional to >> the end. Was this binding already released? I think yes. > > IIUC the intent of the patch is to allow specifying the currently > missing hs_phy_irq on non-multiport controllers (i.e. usb3_[012]). > Bundling the DT change would have made that easier. Yes, I wanted to add the missing hs_phy_irq. I didn't want to bundle in the DT along with the usb binding changes. DT change was posted separately: https://lore.kernel.org/all/20260803-glymur-dt-usb-fixes-v1-1-0f5f52853102@oss.qualcomm.com/ Regards, Krishna,