From: neil.armstrong@linaro.org
To: Jameson Thies <jthies@google.com>,
heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org
Cc: bleung@google.com, abhishekpandit@chromium.org,
andersson@kernel.org, dmitry.baryshkov@linaro.org,
fabrice.gasnier@foss.st.com, gregkh@linuxfoundation.org,
hdegoede@redhat.com, rajaram.regupathy@intel.com,
saranya.gopal@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 4/4] usb: typec: ucsi: Fix SET_PDR typo in UCSI header file
Date: Wed, 17 Jul 2024 09:56:56 +0200 [thread overview]
Message-ID: <06f1b509-220e-415b-a24b-7fe8dc796328@linaro.org> (raw)
In-Reply-To: <20240717004949.3638557-5-jthies@google.com>
On 17/07/2024 02:49, Jameson Thies wrote:
> Fix SET_PDR typo in UCSI header file.
>
> Signed-off-by: Jameson Thies <jthies@google.com>
> ---
> drivers/usb/typec/ucsi/ucsi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
> index 57129f3c0814..375f1881c1e2 100644
> --- a/drivers/usb/typec/ucsi/ucsi.h
> +++ b/drivers/usb/typec/ucsi/ucsi.h
> @@ -152,7 +152,7 @@ void ucsi_connector_change(struct ucsi *ucsi, u8 num);
> #define UCSI_SET_UOR_ROLE(_r_) (((_r_) == TYPEC_HOST ? 1 : 2) << 23)
> #define UCSI_SET_UOR_ACCEPT_ROLE_SWAPS BIT(25)
>
> -/* SET_PDF command bits */
> +/* SET_PDR command bits */
> #define UCSI_SET_PDR_ROLE(_r_) (((_r_) == TYPEC_SOURCE ? 1 : 2) << 23)
> #define UCSI_SET_PDR_ACCEPT_ROLE_SWAPS BIT(25)
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
prev parent reply other threads:[~2024-07-17 7:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 0:49 [PATCH v1 0/4] usb: typec: ucsi: Expand power supply support Jameson Thies
2024-07-17 0:49 ` [PATCH v1 1/4] usb: typec: ucsi: Add status to UCSI power supply driver Jameson Thies
2024-07-17 0:49 ` [PATCH v1 2/4] usb: typec: ucsi: Add USB PD DRP to USB type Jameson Thies
2024-07-17 0:49 ` [PATCH v1 3/4] usb: typec: ucsi: Set power role based on UCSI charge control Jameson Thies
2024-07-22 22:03 ` Jameson Thies
2024-07-17 0:49 ` [PATCH v1 4/4] usb: typec: ucsi: Fix SET_PDR typo in UCSI header file Jameson Thies
2024-07-17 7:56 ` neil.armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06f1b509-220e-415b-a24b-7fe8dc796328@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=abhishekpandit@chromium.org \
--cc=andersson@kernel.org \
--cc=bleung@google.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=fabrice.gasnier@foss.st.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jthies@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rajaram.regupathy@intel.com \
--cc=saranya.gopal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox