From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F5AD210E9 for ; Thu, 14 Sep 2023 14:54:41 +0000 (UTC) Received: from netrider.rowland.org (netrider.rowland.org [192.131.102.5]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 362F11FC8 for ; Thu, 14 Sep 2023 07:54:41 -0700 (PDT) Received: (qmail 996460 invoked by uid 1000); 14 Sep 2023 10:54:40 -0400 Date: Thu, 14 Sep 2023 10:54:40 -0400 From: Alan Stern To: Linyu Yuan Cc: Thinh Nguyen , Chunfeng Yun , Bin Liu , Peter Chen , Pawel Laszczak , Roger Quadros , Steven Rostedt , Masami Hiramatsu , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] usb: gadget: add anonymous definition in some struct for trace purpose Message-ID: <073cbfb2-2f18-4bf7-a313-b16bbcefa8e0@rowland.harvard.edu> References: <20230914100302.30274-1-quic_linyyuan@quicinc.com> <20230914100302.30274-3-quic_linyyuan@quicinc.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230914100302.30274-3-quic_linyyuan@quicinc.com> You didn't include the version number in the Subject: line. Undoubtedly Greg's automatic error checker will warn you about this. Unless the version number is clearly marked for each patch, it's difficult for his programs to tell which email message contains the most recent version. On Thu, Sep 14, 2023 at 06:02:56PM +0800, Linyu Yuan wrote: > Some UDC trace event will save usb udc information, but it use one int > size buffer to save one bit information of usb udc, it is wast trace > buffer. > > Add anonymous union which have one u32 member can be used by trace event > during fast assign stage to save more entries with same trace ring buffer > size. > > Signed-off-by: Linyu Yuan > --- And you didn't include the version change information here, below the "---" line. Apart from that, this is a _lot_ better than before! I don't know if Greg will think this change is worth merging, but at least now it's possible to read the code and understand what's going on. Alan Stern