From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE9FEECAAD8 for ; Wed, 14 Sep 2022 12:25:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229951AbiINMZv (ORCPT ); Wed, 14 Sep 2022 08:25:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbiINMZt (ORCPT ); Wed, 14 Sep 2022 08:25:49 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 005CC28714; Wed, 14 Sep 2022 05:25:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663158347; x=1694694347; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=9ORuF9D4Y/8G7urH0ILcZTwbi7f6D7KyK4hVaHWMMUY=; b=Nv/I8lGr4oEwA90Fc7Fwh7KssskLn28w/3NMiSJ0CeKWBlK5PTepcF+e XxR9BuT+gJcYf0tuTkUnu2KIMGaBwGSRBQVaxWiDsycIVBC3kq4dvaThJ akPUPQDNxz1n3qcJcueLSJPJZH+57V2r1la+aukoUIL/VlGiDkYUHiUQi ET2UMrZCOsrQG4HrGGh+d1HqT0ZVKUwI2Nz1noUctn5zmYHO/UMiPNWsn w34kq/+5AydPmgNW+TArwQifo3AWNKePmGfLhJZ+Za/aYuuiA4ftylc1y f5cekRmI5CIAmLqN/EEDpn7drKY4UIwvZXg62GIE4OyByK0AsELOuNq/I g==; X-IronPort-AV: E=McAfee;i="6500,9779,10470"; a="278142957" X-IronPort-AV: E=Sophos;i="5.93,315,1654585200"; d="scan'208";a="278142957" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2022 05:25:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,315,1654585200"; d="scan'208";a="679023166" Received: from mattu-haswell.fi.intel.com (HELO [10.237.72.199]) ([10.237.72.199]) by fmsmga008.fm.intel.com with ESMTP; 14 Sep 2022 05:25:46 -0700 Message-ID: <07f71b65-b900-62e2-6550-ae89708c9294@linux.intel.com> Date: Wed, 14 Sep 2022 15:27:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Subject: Re: [PATCH] xhci: dbc: Fix memory leak in xhci_alloc_dbc() Content-Language: en-US To: Rafael Mendonca , Mathias Nyman , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220914023609.695296-1-rafaelmendsr@gmail.com> From: Mathias Nyman In-Reply-To: <20220914023609.695296-1-rafaelmendsr@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 14.9.2022 5.36, Rafael Mendonca wrote: > If DbC is already in use, then the allocated memory for the xhci_dbc struct > doesn't get freed before returning NULL, which leads to a memleak. > > Fixes: 534675942e90 ("xhci: dbc: refactor xhci_dbc_init()") > Signed-off-by: Rafael Mendonca Thanks, nice catch Adding to queue -Mathias