Re: [PATCH] usb: uas: do not leak error codes from usb_alloc_streams()

[Sergey Shtylyov <sergei.shtylyov@gmail.com>]

On 10/8/26 4:27 PM, Oliver Neukum wrote:

> While a UAS device is undergoing a reset not triggered by
> the SCSI layer there is a short window in the error case
> of reallocating streams during which internal error codes
> of the USB layer are exported as nonsensical queue depths.
> 
> The error has been noticed by Sashiko in a different
> context, but it is a general issue.
> 
> Fixes: 4de7a3735bdc4 ("uas: Fix reset handling for externally triggered reset")
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> ---
>  drivers/usb/storage/uas.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
> index 265162981269..3f69e9de9b61 100644
> --- a/drivers/usb/storage/uas.c
> +++ b/drivers/usb/storage/uas.c
> @@ -983,10 +983,12 @@ static int uas_configure_endpoints(struct uas_dev_info *devinfo)
>  		devinfo->qdepth = 32;
>  		devinfo->use_streams = 0;
>  	} else {
> -		devinfo->qdepth = usb_alloc_streams(devinfo->intf, eps + 1,
> +		r = usb_alloc_streams(devinfo->intf, eps + 1,
>  						    3, MAX_CMNDS, GFP_NOIO);

   This line now needs to be realigned...

[...]

MBR, Sergey