From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,v1] leds: fix regression in usbport led trigger From: Jacek Anaszewski Message-Id: <0957154d-63de-fefb-4596-2c0eec58dcd5@gmail.com> Date: Tue, 1 Jan 2019 15:54:42 +0100 To: Christian Lamparter Cc: linux-usb@vger.kernel.org, linux-leds@vger.kernel.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Greg Kroah-Hartman List-ID: T24gMS8xLzE5IDM6MDAgUE0sIENocmlzdGlhbiBMYW1wYXJ0ZXIgd3JvdGU6Cj4gSGVsbG8gSmFj ZWssCj4gT24gRnJpZGF5LCBEZWNlbWJlciAyOCwgMjAxOCA1OjI5OjU2IFBNIENFVCBKYWNlayBB bmFzemV3c2tpIHdyb3RlOgo+PiBPbiAxMi8yNS8xOCA5OjQ5IFBNLCBDaHJpc3RpYW4gTGFtcGFy dGVyIHdyb3RlOgo+Pj4gVGhlIHBhdGNoICJ1c2I6IHNpbXBsaWZ5IHVzYnBvcnQgdHJpZ2dlciIg dG9nZXRoZXIgd2l0aAo+Pj4gImxlZHM6IHRyaWdnZXJzOiBhZGQgZGV2aWNlIGF0dHJpYnV0ZSBz dXBwb3J0IiBjYXVzZWQgYW4KPj4+IHJlZ3Jlc3Npb24gZm9yIHRoZSB1c2Jwb3J0IHRyaWdnZXIu IGl0IHdpbGwgbm8gbG9uZ2VyCj4+PiBlbnVtZXJhdGUgYW55IGFjdGl2ZSB1c2IgaHViIHBvcnRz IHVuZGVyIHRoZSAicG9ydHMiCj4+PiBkaXJlY3RvcnkgaW4gdGhlIHN5c2ZzIGNsYXNzIGRpcmVj dG9yeSwgaWYgdGhlIHVzYiBob3N0Cj4+PiBkcml2ZXJzIGFyZSBmdWxseSBpbml0aWFsaXplZCBi ZWZvcmUgdGhlIHVzYnBvcnQgdHJpZ2dlcgo+Pj4gd2FzIGxvYWRlZC4KPj4+Cj4+PiBUaGUgcmVh c29uIGlzIHRoYXQgdGhlIHVzYnBvcnQgZHJpdmVyIHRyaWVzIHRvIHJlZ2lzdGVyCj4+PiB0aGUg c3lzZnMgZW50cmllcyBkdXJpbmcgdGhlIGFjdGl2YXRlKCkgY2FsbGJhY2suIEFuZCB0aGlzCj4+ PiB3aWxsIGZhaWwgd2l0aCAtMiAvIEVOT0VOVCBiZWNhdXNlIHRoZSBwYXRjaAo+Pj4gImxlZHM6 IHRyaWdnZXJzOiBhZGQgZGV2aWNlIGF0dHJpYnV0ZSBzdXBwb3J0IiBtYWRlIGl0IHNvCj4+PiB0 aGF0IHRoZSBzeXNmcyAicG9ydHMiIGdyb3VwIHdhcyBvbmx5IGJlaW5nIGFkZGVkIGFmdGVyCj4+ PiB0aGUgYWN0aXZhdGUoKSBjYWxsYmFjayBzdWNjZWVkZWQuCj4+Pgo+Pj4gVGhpcyB2ZXJzaW9u IG9mIHRoZSBwYXRjaCBtb3ZlcyB0aGUgZGV2aWNlX2FkZF9ncm91cHMoKQo+Pj4gaW4gZnJvbnQg b2YgdGhlIGNhbGwgdG8gdGhlIHRyaWdnZXIncyBhY3RpdmF0ZSgpIGZ1bmN0aW9uCj4+PiBpbiBv cmRlciB0byBzb2x2ZSB0aGUgcHJvYmxlbS4KPj4+Cj4+PiBDYzogR3JlZyBLcm9haC1IYXJ0bWFu IDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz4KPj4+IENjOiBVd2UgS2xlaW5lLUvDtm5pZyA8 dS5rbGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPgo+Pj4gQ2M6IFJhZmHFgiBNacWCZWNraSA8 emFqZWM1QGdtYWlsLmNvbT4KPj4+IEZpeGVzOiA2ZjdiMGJhZDg4MzkgKCJ1c2I6IHNpbXBsaWZ5 IHVzYnBvcnQgdHJpZ2dlciIpCj4+PiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RpYW4gTGFtcGFydGVy IDxjaHVua2VleUBnbWFpbC5jb20+Cj4+PiAtLS0KPj4+Cj4+PiBUaGlzIHZlcnNpb24gb2YgdGhl IHBhdGNoIC4uLiBvZiB3aGljaCB3aWxsIGJlIG1hbnkgbW9yZT8hCj4+Pgo+Pj4geWVhaCwgZGV2 aWNlX2FkZF9ncm91cHMoKSBpbiBmcm9udCBvZiBhY3RpdmF0ZSgpIHdvcmtzCj4+PiBmb3IgdGhl IHVzYnBvcnQgZHJpdmVyIHNpbmNlIGl0IGR5bmFtaWNhbGx5IHJlZ2lzdGVycwo+Pj4gdGhlIGVu dHJpZXMgaW4gInBvcnRzIi4gSG93ZXZlciwgaWYgYSB0cmlnZ2VyIGhhcyBhCj4+PiBzdGF0aWMg bGlzdCBvZiBlbnRpdGllcyB0aGlzIGNhbiBnZXQgbW9yZSBjb21wbGljYXRlZCwKPj4+IHNpbmNl IEkgdGhpbmsgdGhlIHN5c2ZzIGVudHJpZXMgd2lsbCBub3cgYmUgYXZhaWxhYmxlCj4+PiBiZWZv cmUgdGhlIGFjdGl2YXRlKCkgY2FsbCBldmVuIHN0YXJ0ZWQgYW5kIHRoaXMgY2FuCj4+PiBlbmQg dXAgYmFkbHkuIFNvLCBpcyB0aGVyZSBhbnkgYmV0dGVyIGFwcHJvYWNoPwo+Pj4gSW50cm9kdWNl IGEgInBvc3RfYWN0aXZhdGUoKSIgY2FsbGJhY2s/IE9yIHVzZSB0aGUgZXZlbnQKPj4+IHN5c3Rl bSBhbmQgbWFrZSB1c2Jwb3J0IHRyaWdnZXIgb24gdGhlIEtPQkpfQ0hBTkdFPyB1c2UKPj4+IGEg KGRlbGF5ZWQpIHdvcmtfc3RydWN0IGluIHVzYnBvcnQgdG8gcmVnaXN0ZXIgdGhlIHBvcnRzCj4+ PiBhdCBhIHNsaWdodGx5IGxhdGVyIHRpbWU/IGV0Yy4uLgo+Pgo+PiBwb3N0X2FjdGl2YXRlKCkg aXMgYW4gb3B0aW9uLgo+IEkgd2FzIHRvbGQgdG8gd2FpdCBhIGJpdCBtb3JlIGJlY2F1c2UgcGFy dHMgb2YgRXVyb3BlIGFyZQo+IHN0aWxsIGVuam95aW5nIHRoZSBob2xpZGF5cy4gSGFwcHkgTmV3 IFllYXIuIDotRAoKSGFwcHkgTmV3IFllYXIgOi0pCgo+PiBPdGhlcndpc2UsIHdpdGggeW91ciBw YXRjaCwgaW4gb3JkZXIgdG8gcHJldmVudCBhY2Nlc3MgdG8gdGhlIHN5c2ZzCj4+IGludGVyZmFj ZSBiZWZvcmUgdGhlIHRyaWdnZXIgaXMgaW5pdGlhbGl6ZWQsIHdlIHdvdWxkIGhhdmUgdG8gaW1w bGVtZW50Cj4+IGlzX3Zpc2libGUgb3AgZm9yIGVhY2ggc3RydWN0IGF0dHJpYnV0ZV9ncm91cCBp biB0aGUgdHJpZ2dlcnMKPj4gd2l0aCBzdGF0aWMgYXR0cnMsIGFuZCBjaGVjayBsZWRfY2Rldi0+ YWN0aXZhdGVkIHRoZXJlCj4+IChpdCBpcyBjdXJyZW50bHkgdW51c2VkIGFuZCBzY2hlZHVsZWQg Zm9yIHJlbW92YWwsIGJ1dCB3ZQo+PiB3b3VsZCBoYXZlIHRvIHNldCBpdCBhZnRlciBjYWxsaW5n IGFjdGl2YXRlKCkgaW4gTEVEIHRyaWdnZXIgY29yZSkuCj4gIEZyb20gd2hhdCBJIGNhbiB0ZWxs IGJ5IGxvb2tpbmcgYXQgYSBsb3Qgb2YgbGVkIHRyaWdnZXJzLCBvbmx5IHRoZSB1c2Jwb3J0Cj4g bGVkIHRyaWdnZXIgaXMgYWZmZWN0ZWQuIFNvIGFub3RoZXIgc2Vuc2libGUgb3B0aW9uIGNvdWxk IGJlIHRvIHBhcnRpYWxseQo+IHJldmVydCA2ZjdiMGJhZDg4MzkgKCJ1c2I6IHNpbXBsaWZ5IHVz YnBvcnQgdHJpZ2dlciIpIGFuZCBsZXQgdGhlIHVzYnBvcnQKPiB0cmlnZ2VyIG1hbmFnZSBpdHMg c3lzZnMgZ3JvdXBzIGJ5IGl0c2VsZi4gKHNlZSBiZWxvdykuIFdoYXQgZG8geW91IHRoaW5rPwoK V29ya3MgZm9yIG1lLCBidXQgeW91J2xsIG5lZWQgdGhlIGFwcHJvdmFsIGZyb20gdGhlIG90aGVy IHNpZGUsCnNpbmNlIHRoaXMgZG9lcyBub3QgYmVsb25nIHRvIHRoZSBMRUQgc3Vic3lzdGVtLgoK QWNrZWQtYnk6IEphY2VrIEFuYXN6ZXdza2kgPGphY2VrLmFuYXN6ZXdza2lAZ21haWwuY29tPgoK PiAtLS0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2IvY29yZS9sZWR0cmlnLXVzYnBvcnQuYyBi L2RyaXZlcnMvdXNiL2NvcmUvbGVkdHJpZy11c2Jwb3J0LmMKPiBpbmRleCBkYzdmN2ZkNzE2ODQu LmMxMmFjNTY2MDZjMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3VzYi9jb3JlL2xlZHRyaWctdXNi cG9ydC5jCj4gKysrIGIvZHJpdmVycy91c2IvY29yZS9sZWR0cmlnLXVzYnBvcnQuYwo+IEBAIC0x MTksMTEgKzExOSw2IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgYXR0cmlidXRlX2dyb3VwIHBvcnRz X2dyb3VwID0gewo+ICAgCS5hdHRycyA9IHBvcnRzX2F0dHJzLAo+ICAgfTsKPiAgIAo+IC1zdGF0 aWMgY29uc3Qgc3RydWN0IGF0dHJpYnV0ZV9ncm91cCAqcG9ydHNfZ3JvdXBzW10gPSB7Cj4gLQkm cG9ydHNfZ3JvdXAsCj4gLQlOVUxMCj4gLX07Cj4gLQo+ICAgLyoqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKgo+ICAgICogQWRkaW5nICYgcmVtb3ZpbmcgcG9ydHMKPiAgICAq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKiovCj4gQEAgLTMwNyw2ICszMDIs NyBAQCBzdGF0aWMgaW50IHVzYnBvcnRfdHJpZ19ub3RpZnkoc3RydWN0IG5vdGlmaWVyX2Jsb2Nr ICpuYiwgdW5zaWduZWQgbG9uZyBhY3Rpb24sCj4gICBzdGF0aWMgaW50IHVzYnBvcnRfdHJpZ19h Y3RpdmF0ZShzdHJ1Y3QgbGVkX2NsYXNzZGV2ICpsZWRfY2RldikKPiAgIHsKPiAgIAlzdHJ1Y3Qg dXNicG9ydF90cmlnX2RhdGEgKnVzYnBvcnRfZGF0YTsKPiArCWludCBlcnI7Cj4gICAKPiAgIAl1 c2Jwb3J0X2RhdGEgPSBremFsbG9jKHNpemVvZigqdXNicG9ydF9kYXRhKSwgR0ZQX0tFUk5FTCk7 Cj4gICAJaWYgKCF1c2Jwb3J0X2RhdGEpCj4gQEAgLTMxNSw2ICszMTEsOSBAQCBzdGF0aWMgaW50 IHVzYnBvcnRfdHJpZ19hY3RpdmF0ZShzdHJ1Y3QgbGVkX2NsYXNzZGV2ICpsZWRfY2RldikKPiAg IAo+ICAgCS8qIExpc3Qgb2YgcG9ydHMgKi8KPiAgIAlJTklUX0xJU1RfSEVBRCgmdXNicG9ydF9k YXRhLT5wb3J0cyk7Cj4gKwllcnIgPSBzeXNmc19jcmVhdGVfZ3JvdXAoJmxlZF9jZGV2LT5kZXYt PmtvYmosICZwb3J0c19ncm91cCk7Cj4gKwlpZiAoZXJyKQo+ICsJCWdvdG8gZXJyX2ZyZWU7Cj4g ICAJdXNiX2Zvcl9lYWNoX2Rldih1c2Jwb3J0X2RhdGEsIHVzYnBvcnRfdHJpZ19hZGRfdXNiX2Rl dl9wb3J0cyk7Cj4gICAJdXNicG9ydF90cmlnX3VwZGF0ZV9jb3VudCh1c2Jwb3J0X2RhdGEpOwo+ ICAgCj4gQEAgLTMyMiw4ICszMjEsMTEgQEAgc3RhdGljIGludCB1c2Jwb3J0X3RyaWdfYWN0aXZh dGUoc3RydWN0IGxlZF9jbGFzc2RldiAqbGVkX2NkZXYpCj4gICAJdXNicG9ydF9kYXRhLT5uYi5u b3RpZmllcl9jYWxsID0gdXNicG9ydF90cmlnX25vdGlmeTsKPiAgIAlsZWRfc2V0X3RyaWdnZXJf ZGF0YShsZWRfY2RldiwgdXNicG9ydF9kYXRhKTsKPiAgIAl1c2JfcmVnaXN0ZXJfbm90aWZ5KCZ1 c2Jwb3J0X2RhdGEtPm5iKTsKPiAtCj4gICAJcmV0dXJuIDA7Cj4gKwo+ICtlcnJfZnJlZToKPiAr CWtmcmVlKHVzYnBvcnRfZGF0YSk7Cj4gKwlyZXR1cm4gZXJyOwo+ICAgfQo+ICAgCj4gICBzdGF0 aWMgdm9pZCB1c2Jwb3J0X3RyaWdfZGVhY3RpdmF0ZShzdHJ1Y3QgbGVkX2NsYXNzZGV2ICpsZWRf Y2RldikKPiBAQCAtMzM1LDYgKzMzNyw4IEBAIHN0YXRpYyB2b2lkIHVzYnBvcnRfdHJpZ19kZWFj dGl2YXRlKHN0cnVjdCBsZWRfY2xhc3NkZXYgKmxlZF9jZGV2KQo+ICAgCQl1c2Jwb3J0X3RyaWdf cmVtb3ZlX3BvcnQodXNicG9ydF9kYXRhLCBwb3J0KTsKPiAgIAl9Cj4gICAKPiArCXN5c2ZzX3Jl bW92ZV9ncm91cCgmbGVkX2NkZXYtPmRldi0+a29iaiwgJnBvcnRzX2dyb3VwKTsKPiArCj4gICAJ dXNiX3VucmVnaXN0ZXJfbm90aWZ5KCZ1c2Jwb3J0X2RhdGEtPm5iKTsKPiAgIAo+ICAgCWtmcmVl KHVzYnBvcnRfZGF0YSk7Cj4gQEAgLTM0NCw3ICszNDgsNiBAQCBzdGF0aWMgc3RydWN0IGxlZF90 cmlnZ2VyIHVzYnBvcnRfbGVkX3RyaWdnZXIgPSB7Cj4gICAJLm5hbWUgICAgID0gInVzYnBvcnQi LAo+ICAgCS5hY3RpdmF0ZSA9IHVzYnBvcnRfdHJpZ19hY3RpdmF0ZSwKPiAgIAkuZGVhY3RpdmF0 ZSA9IHVzYnBvcnRfdHJpZ19kZWFjdGl2YXRlLAo+IC0JLmdyb3VwcyA9IHBvcnRzX2dyb3VwcywK PiAgIH07Cj4gICAKPiAgIHN0YXRpYyBpbnQgX19pbml0IHVzYnBvcnRfdHJpZ19pbml0KHZvaWQp Cj4gCj4gCj4gCj4gCj4gCj4K