From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F99F1B9B2D; Wed, 14 Aug 2024 17:20:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723656053; cv=none; b=Iqr3ynDDEl+oI6im+TqF6XlBsmzp1LIRJ4AiJdLvxu7l4c/mYW+pOiQolJdRTOgHijX1lnNwMA8bS9wgkE9AXVvEj79rRQlFkfwCNHws1hLEDOGb6Lq0eNsCzyZTGYWusUDZbdJ4I/R4PBhbO9HUaT5F/8Gp2EAY1PXyt7P9Znk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723656053; c=relaxed/simple; bh=smuak+zqjyB1uSWmMRGThmE3BA9R58lXtjJBjh3OZVE=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=HgXRwwzY4syKDlhl46puuC1dIbrfLT+xHU9B7h8Tx/cgc6H2x1EQHJjhLOi2FWUUn09nFmzIF7FfvLTNHeufEassvMh1aR+BAQmxl7aKXcHCoyetJPIcpGb7l71kS97QMUj1gDYdrd73eX6jIOpSKnTHjdbMSFVTiBA/pEc/yMY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=owe/A3ZV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="owe/A3ZV" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 47EADMr7026876; Wed, 14 Aug 2024 17:20:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xRGpGeGkdYD2yIn+lOnT/kFxW5i6tGEXWoAkx9Y3rLk=; b=owe/A3ZVYisipyZ6 CGUy2B/c9dQcTpg5jzKmlOgwNAlA8V6BZQiUcqVJJOyuoNgmqe3o99WB3Cn05GWf rokvHpRc7GvB1wfWC/5HMfoK6/d5+z+Gd5hBDXyUiKNWWONshvSkic0PRxyIgECX V7fSGxgzXkAxgCWLLbAc0lmlBArAiucf+k0jFEpV08VmJadNGRulnqZrLV8d+cje Qm8RdB5tOfykSvhWqPzUVJ6THfMvLsTygwjWaCL0zJyFbZgGPM3zhDpzShrDlem6 dYeunkkc43t0YB5mIkMYEmLvzcCURLqKboc3jBD03NOAU0dRbKkif3THqM9Ph50X Hrq8JA== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 40x18y433m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Aug 2024 17:20:46 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 47EHKjt9015895 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Aug 2024 17:20:45 GMT Received: from [10.71.108.157] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 14 Aug 2024 10:20:44 -0700 Message-ID: <09bc73fc-65bd-41b5-90fa-14cb0ff79e77@quicinc.com> Date: Wed, 14 Aug 2024 10:20:45 -0700 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/3] dt-bindings: soc: qcom: eud: Update compatible strings for eud To: Krzysztof Kozlowski , Souradeep Chowdhury , Bjorn Andersson , "Konrad Dybcio" , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , "Greg Kroah-Hartman" , Trilok Soni , Satya Durga Srinivasu Prabhala , Elson Serrao CC: , , , , References: <20240807183205.803847-1-quic_molvera@quicinc.com> <20240807183205.803847-2-quic_molvera@quicinc.com> <46d0627d-877b-41f3-83f6-4c33b562f460@quicinc.com> <0ebb1ca3-722d-422f-9f71-fcc61c3470b0@kernel.org> Content-Language: en-US From: Melody Olvera In-Reply-To: <0ebb1ca3-722d-422f-9f71-fcc61c3470b0@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: jvUOOiqhtBKs0QxiF-nyMuRz6b4avE9p X-Proofpoint-ORIG-GUID: jvUOOiqhtBKs0QxiF-nyMuRz6b4avE9p X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-14_13,2024-08-13_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=934 suspectscore=0 phishscore=0 malwarescore=0 mlxscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2408140118 On 8/13/2024 11:15 PM, Krzysztof Kozlowski wrote: > On 13/08/2024 22:03, Melody Olvera wrote: >> >> On 8/8/2024 4:00 AM, Krzysztof Kozlowski wrote: >>> On 07/08/2024 20:32, Melody Olvera wrote: >>>> The EUD can more accurately be divided into two types; a secure type >>>> which requires that certain registers be updated via scm call and a >>>> nonsecure type which must access registers nonsecurely. Thus, change >>>> the compatible strings to reflect secure and nonsecure eud usage. >>>> >>>> Signed-off-by: Melody Olvera >>>> --- >>>> Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml | 6 +++--- >>>> 1 file changed, 3 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml >>>> index f2c5ec7e6437..476f92768610 100644 >>>> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml >>>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml >>>> @@ -17,8 +17,8 @@ properties: >>>> compatible: >>>> items: >>>> - enum: >>>> - - qcom,sc7280-eud >>>> - - const: qcom,eud >>>> + - qcom,secure-eud >>>> + - qcom,eud >>> Commit msg did not explain me why DT bindings rules are avoided here and >>> you drop existing SoC specific compatible. >>> >>> This really does not look like having any sense at all, I cannot come up >>> with logic behind dropping existing users. You could deprecate it, but >>> then why exactly this device should have exception from generic bindings >>> rule? >> Understood. I won't drop this compatible string. Is alright to add the >> additional compatible as is? > You always need SoC specific compatible. Got it. Will change to SoC specific then. Thanks, Melody