From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 631D6C4332F for ; Tue, 17 May 2022 14:53:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349431AbiEQOx4 (ORCPT ); Tue, 17 May 2022 10:53:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349304AbiEQOxr (ORCPT ); Tue, 17 May 2022 10:53:47 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AD4F2C673 for ; Tue, 17 May 2022 07:53:38 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id m23so22094872ljc.0 for ; Tue, 17 May 2022 07:53:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=98lrMyDx9nA58tX+jL8WsvjaXFJ5bPfTC4nB38BPHxA=; b=x9dx0SlO4F+EkMbBg+vshW88M1gEMckHm0L13WDfzZo5c4+BVCTmrbAdnJ98gufYJe Qmf4hd07LDsg6x1ZYTY8fQRD+qwnKQqEaqSHOxwf8CwwGwozgEkqQ5wn3k297ne+94Lu 10/RKKdcjfqL7DzHy/z/Kh5cWmJ1mh2DFzqTnLTS5JSAlOcy6yTHk745eI1I16HuRLPi +BPF/07xb2jWxwr35+dsqwKrBN7oLLmgdIR1oo1SaIAIZDK5CTJXESaVi55t+rvO8Woh Cyh4OYqy/lTKbOr0y3+SFEmVPs6wxSz+h7W+MS30+uUq3kWSwySQimWQ04pqLHNAe3ij HKNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=98lrMyDx9nA58tX+jL8WsvjaXFJ5bPfTC4nB38BPHxA=; b=PDa9LbEEIAw1FMopZqonhB3ZKDgMEKLQCjln51EXPiFuaC1JPaXCa/rYtJa0+eYfZY w+CltklXEYG9qtt7JgSa+p3fIfj/BlDKNGfFB/CVqGYwrOKIHM7zHQiCHcKTco4KZL/N msm0vDulbGaMty8gvPHAlhwQimtCMzKm6/ShjyKC0Tt+66K3auVav7fZx6O0ZRyWAVkP yIVBARu7SKIBy2JCBOLq1drTm6G89ber0kCHZ5z5jeTYLASbmQoxVV7yd8U1vtk/e9bt dt/LAUm2In4IftE8dj80j89+brHZ9aGHejAi4U1hWojtzW45Y/r6275QbvrK9VFfGgUj BxZQ== X-Gm-Message-State: AOAM532nNvjl3JIDOvjeC1Xf6Nr3pF2oBcRckDmiNsnI/aJ9r7VU8K8O PBK5CKV4twE6XxaoZfp1G4TQuA== X-Google-Smtp-Source: ABdhPJyWvHzwFXV4y4dwE1Mg+4vxEcyCuwAK4eajYXdjTegf080biutfjdxui5eX5IbFoPm6jzW9uQ== X-Received: by 2002:a2e:9d08:0:b0:250:d483:d734 with SMTP id t8-20020a2e9d08000000b00250d483d734mr14679734lji.406.1652799215969; Tue, 17 May 2022 07:53:35 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id w17-20020ac254b1000000b0047255d210f8sm1611527lfk.39.2022.05.17.07.53.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 May 2022 07:53:35 -0700 (PDT) Message-ID: <0bc5ba24-5bfb-593e-cbd0-828ef44aabc5@linaro.org> Date: Tue, 17 May 2022 16:53:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 2/3] ARM: dts: aspeed: Add USB2.0 device controller node Content-Language: en-US To: Neal Liu , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Felipe Balbi , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= , Geert Uytterhoeven , Li Yang Cc: "linux-aspeed@lists.ozlabs.org" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linaro-mm-sig@lists.linaro.org" References: <20220517082558.3534161-1-neal_liu@aspeedtech.com> <20220517082558.3534161-3-neal_liu@aspeedtech.com> <96973d1d-c52c-d190-6989-3f7996dae70b@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 17/05/2022 16:50, Neal Liu wrote: >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Tuesday, May 17, 2022 8:00 PM >> To: Neal Liu ; Greg Kroah-Hartman >> ; Rob Herring ; Krzysztof >> Kozlowski ; Joel Stanley ; >> Andrew Jeffery ; Felipe Balbi ; Sumit >> Semwal ; Christian König >> ; Geert Uytterhoeven ; >> Li Yang >> Cc: linux-aspeed@lists.ozlabs.org; linux-usb@vger.kernel.org; >> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; >> linux-kernel@vger.kernel.org; linux-media@vger.kernel.org; >> dri-devel@lists.freedesktop.org; linaro-mm-sig@lists.linaro.org >> Subject: Re: [PATCH v2 2/3] ARM: dts: aspeed: Add USB2.0 device controller >> node >> >> On 17/05/2022 10:25, Neal Liu wrote: >>> Add USB2.0 device controller(udc) node to device tree for AST2600. >>> >>> Signed-off-by: Neal Liu >>> --- >>> arch/arm/boot/dts/aspeed-g6.dtsi | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi >>> b/arch/arm/boot/dts/aspeed-g6.dtsi >>> index 3d5ce9da42c3..5517313eb2b5 100644 >>> --- a/arch/arm/boot/dts/aspeed-g6.dtsi >>> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi >>> @@ -298,6 +298,16 @@ vhub: usb-vhub@1e6a0000 { >>> status = "disabled"; >>> }; >>> >>> + udc: udc@1e6a2000 { >> >> The same as DTS in bindings - generic node name, please. >> > > Is it possible to use "udc: usb-udc@1e6a2000" to distinguish it between "vhub: usb-vhub@1e6a0000"? Possible yes :), but not recommended and not wanted. Nodes should be generic and prefixes are added only if there is no unit address. You can though use some more descriptive label. Best regards, Krzysztof