From: Oliver Neukum <oneukum@suse.com>
To: Dave Carey <carvsdriver@gmail.com>, oneukum@suse.com
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: cdc-acm: Add quirks for Yoga Book 9 14IAH10 INGENIC touchscreen
Date: Thu, 2 Apr 2026 20:56:45 +0200 [thread overview]
Message-ID: <0c1ab966-97b0-49b3-989e-c6bd2a8d1c79@suse.com> (raw)
In-Reply-To: <20260402182950.389016-1-carvsdriver@gmail.com>
On 02.04.26 20:29, Dave Carey wrote:
> The Lenovo Yoga Book 9 14IAH10 (83KJ) has a composite USB device
> (17EF:6161) that controls both touchscreens via a CDC ACM interface.
> Interface 0 is a standard CDC ACM control interface, but interface 1
> (the data interface) incorrectly declares vendor-specific class (0xFF)
> instead of USB_CLASS_CDC_DATA. cdc-acm rejects the device at probe with
> -EINVAL, leaving interface 0 unbound and EP 0x82 never polled.
>
> With no consumer polling EP 0x82, the firmware's watchdog fires every
> ~20 seconds and resets the USB bus, producing a continuous disconnect/
> reconnect loop that prevents the touchscreens from ever initialising.
>
> Add two new quirk flags:
>
> VENDOR_CLASS_DATA_IFACE: Bypasses the bInterfaceClass check in
> acm_probe() that would otherwise reject the vendor-class data
> interface with -EINVAL.
>
> ALWAYS_POLL_CTRL: Submits the notification URB at probe() rather than
> waiting for a TTY open. This keeps EP 0x82 polled at all times,
> permanently suppressing the firmware watchdog. The URB is resubmitted
> after port_shutdown() and on system resume. SET_CONTROL_LINE_STATE
> (DTR|RTS) is sent at probe and after port_shutdown() to complete
> firmware handshake.
>
> Note: the firmware performs exactly 4 USB connect/disconnect cycles
> (~19 s each) on every cold boot before stabilising. This is a fixed
> firmware property; touch is available ~75-80 s after power-on.
>
> Signed-off-by: Dave Carey <carvsdriver@gmail.com>
> Tested-by: Dave Carey <carvsdriver@gmail.com>
Acked-by: Oliver Neukum <oneukum@suse.com>
prev parent reply other threads:[~2026-04-02 18:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 18:29 [PATCH] USB: cdc-acm: Add quirks for Yoga Book 9 14IAH10 INGENIC touchscreen Dave Carey
2026-04-02 18:56 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c1ab966-97b0-49b3-989e-c6bd2a8d1c79@suse.com \
--to=oneukum@suse.com \
--cc=carvsdriver@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox