From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C01436A for ; Fri, 15 Sep 2023 01:03:22 +0000 (UTC) Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D0B62701; Thu, 14 Sep 2023 18:03:21 -0700 (PDT) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38F13AJu003969; Fri, 15 Sep 2023 01:03:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=rLjzwPj1LfT4JwZQbqkx+0bG5CckwAD2wtNxHJQAW0Q=; b=Hp19j4choIKUkmrxMepI2ZZevMbWoxma0v+eKPqXbcVVt5Zx3flL1IdlpBDuMN9ZDtOA prVK+MY6q0hWlM+hf+HAmvWvtoNjr4bPL7jdpFAX5rj95gg6a6rQFMq+pLRPEHhoLZPg +hjJLXXFjSZEmQs67CnhWCiLw1/BolCqi/8998T2BGY6ECRq2sjCE0aVLxd2yKlb7emQ zExKz8YG5UJgAANQrPZ9/3I/45+3RNOkQTqUQW+NZAmaUyn0vFbxyG0ECkAFnPKXOu0C 6coRvwrsCpatgvZ97z/HuDg0PStrETeq9P5+sx0rpmHzU78DOdHn2PG+SowEKgpqkmyM CA== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t4d65806s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Sep 2023 01:03:10 +0000 Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38F12tuF011467 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Sep 2023 01:02:55 GMT Received: from [10.253.37.179] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Thu, 14 Sep 2023 18:02:51 -0700 Message-ID: <0c2ba115-826e-40d6-73ac-7ed67302c8eb@quicinc.com> Date: Fri, 15 Sep 2023 09:02:48 +0800 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 2/8] usb: gadget: add anonymous definition in some struct for trace purpose Content-Language: en-US To: Alan Stern CC: Thinh Nguyen , Chunfeng Yun , Bin Liu , Peter Chen , Pawel Laszczak , Roger Quadros , Steven Rostedt , Masami Hiramatsu , Greg Kroah-Hartman , , References: <20230914100302.30274-1-quic_linyyuan@quicinc.com> <20230914100302.30274-3-quic_linyyuan@quicinc.com> <073cbfb2-2f18-4bf7-a313-b16bbcefa8e0@rowland.harvard.edu> From: Linyu Yuan In-Reply-To: <073cbfb2-2f18-4bf7-a313-b16bbcefa8e0@rowland.harvard.edu> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: xXTFhN6ndxQQYKJu9lApdS0REtxRP1F7 X-Proofpoint-ORIG-GUID: xXTFhN6ndxQQYKJu9lApdS0REtxRP1F7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-14_13,2023-09-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=1 adultscore=0 mlxlogscore=204 mlxscore=1 impostorscore=0 lowpriorityscore=0 spamscore=1 suspectscore=0 bulkscore=0 phishscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309150007 On 9/14/2023 10:54 PM, Alan Stern wrote: > You didn't include the version number in the Subject: line. Undoubtedly > Greg's automatic error checker will warn you about this. Unless the > version number is clearly marked for each patch, it's difficult for his > programs to tell which email message contains the most recent version. > > On Thu, Sep 14, 2023 at 06:02:56PM +0800, Linyu Yuan wrote: >> Some UDC trace event will save usb udc information, but it use one int >> size buffer to save one bit information of usb udc, it is wast trace >> buffer. >> >> Add anonymous union which have one u32 member can be used by trace event >> during fast assign stage to save more entries with same trace ring buffer >> size. >> >> Signed-off-by: Linyu Yuan >> --- > And you didn't include the version change information here, below the > "---" line. > > Apart from that, this is a _lot_ better than before! I don't know if > Greg will think this change is worth merging, but at least now it's > possible to read the code and understand what's going on. according Steven's comment, maybe will always save data in little endian at trace event fast assign stage. it will add definition of bit field back. > > Alan Stern