From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8415C54FD0 for ; Wed, 25 Mar 2020 13:35:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C41E72078A for ; Wed, 25 Mar 2020 13:35:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727877AbgCYNfe (ORCPT ); Wed, 25 Mar 2020 09:35:34 -0400 Received: from mail-sh.amlogic.com ([58.32.228.43]:32827 "EHLO mail-sh.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727444AbgCYNfb (ORCPT ); Wed, 25 Mar 2020 09:35:31 -0400 Received: from [10.18.38.73] (10.18.38.73) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Wed, 25 Mar 2020 21:36:06 +0800 Subject: Re: [PATCH 02/13] usb: dwc3: meson-g12a: specify phy names in soc data To: Martin Blumenstingl , Neil Armstrong CC: , , , , , , References: <20200324102030.31000-1-narmstrong@baylibre.com> <20200324102030.31000-3-narmstrong@baylibre.com> From: Hanjie Lin Message-ID: <0cc6076c-1334-026f-c7ce-32a5945351b5@amlogic.com> Date: Wed, 25 Mar 2020 21:36:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.18.38.73] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 2020/3/24 22:19, Martin Blumenstingl wrote: > On Tue, Mar 24, 2020 at 3:17 PM Neil Armstrong wrote: >> >> On 24/03/2020 15:13, Martin Blumenstingl wrote: >>> Hi Neil, >>> >>> On Tue, Mar 24, 2020 at 11:20 AM Neil Armstrong wrote: >>> [...] >>>> +static const char *meson_a1_phy_names[] = { >>>> + "usb2-phy0", "usb2-phy1" >>>> +}; >>> my understanding is that the A1 SoC only has usb2-phy1. >>> +Cc Hanjie Lin to confirm this >> >> I forgot a comment here, it only has a single PHY, but still the 2 U2 PHY >> controls slots... it would need a large amount of code to handle this >> tweak, and leaving 2 PHYs keeps the behavior before the patchset. > I just reviewed patch #3 and I now understand that it would require a > large code-change > I'm fine with a comment > > > Martin > > . > I see, A comment here will be more comprehensible. Acked-by: Hanjie Lin Hanjie