From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Marek Vasut <marex@denx.de>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Cc: Richard Leitner <richard.leitner@skidata.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS: rectify entry for MICROCHIP USB251XB DRIVER
Date: Tue, 15 Nov 2022 11:54:15 +0100 [thread overview]
Message-ID: <0eb1a6a5-771c-6cc1-f95b-9708468f1d90@linaro.org> (raw)
In-Reply-To: <0750d2e8-766b-3c5c-5472-4c9d6e9ec3c4@denx.de>
On 15/11/2022 11:52, Marek Vasut wrote:
> On 11/15/22 11:35, Krzysztof Kozlowski wrote:
>> On 15/11/2022 11:31, Lukas Bulwahn wrote:
>>> Commit fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema")
>>> converts usb251xb.txt to usb251xb.yaml, but misses to adjust its reference
>>> in MAINTAINERS.
>>>
>>> Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
>>> broken reference.
>>>
>>> Repair this file reference in MICROCHIP USB251XB DRIVER.
>>>
>> You know this could be just one sentence (instead of three paragraphs)
>> with a Fixes tag...
>
> On the other hand, the content is educational, e.g. about the usage of
> get_maintainer.pl script .
Education is good, but I don't see a point to grow commit log with this.
The warning would be useful, but the command? Just store it in
Documentation if the intention is to educate.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-11-15 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 10:31 [PATCH] MAINTAINERS: rectify entry for MICROCHIP USB251XB DRIVER Lukas Bulwahn
2022-11-15 10:35 ` Krzysztof Kozlowski
2022-11-15 10:52 ` Marek Vasut
2022-11-15 10:54 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0eb1a6a5-771c-6cc1-f95b-9708468f1d90@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=marex@denx.de \
--cc=richard.leitner@skidata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).