linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] MAINTAINERS: rectify entry for MICROCHIP USB251XB DRIVER
@ 2022-11-15 10:31 Lukas Bulwahn
  2022-11-15 10:35 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 4+ messages in thread
From: Lukas Bulwahn @ 2022-11-15 10:31 UTC (permalink / raw)
  To: Marek Vasut, Greg Kroah-Hartman, linux-usb
  Cc: Krzysztof Kozlowski, Richard Leitner, kernel-janitors,
	linux-kernel, Lukas Bulwahn

Commit fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema")
converts usb251xb.txt to usb251xb.yaml, but misses to adjust its reference
in MAINTAINERS.

Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
broken reference.

Repair this file reference in MICROCHIP USB251XB DRIVER.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Marek, please ack.

Greg, please pick this minor non-urgent patch on top of the commit above.

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index fdcf1e020a5a..43f9e2abe893 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -13726,7 +13726,7 @@ MICROCHIP USB251XB DRIVER
 M:	Richard Leitner <richard.leitner@skidata.com>
 L:	linux-usb@vger.kernel.org
 S:	Maintained
-F:	Documentation/devicetree/bindings/usb/usb251xb.txt
+F:	Documentation/devicetree/bindings/usb/usb251xb.yaml
 F:	drivers/usb/misc/usb251xb.c
 
 MICROCHIP USBA UDC DRIVER
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] MAINTAINERS: rectify entry for MICROCHIP USB251XB DRIVER
  2022-11-15 10:31 [PATCH] MAINTAINERS: rectify entry for MICROCHIP USB251XB DRIVER Lukas Bulwahn
@ 2022-11-15 10:35 ` Krzysztof Kozlowski
  2022-11-15 10:52   ` Marek Vasut
  0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-15 10:35 UTC (permalink / raw)
  To: Lukas Bulwahn, Marek Vasut, Greg Kroah-Hartman, linux-usb
  Cc: Richard Leitner, kernel-janitors, linux-kernel

On 15/11/2022 11:31, Lukas Bulwahn wrote:
> Commit fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema")
> converts usb251xb.txt to usb251xb.yaml, but misses to adjust its reference
> in MAINTAINERS.
> 
> Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
> broken reference.
> 
> Repair this file reference in MICROCHIP USB251XB DRIVER.
> 
You know this could be just one sentence (instead of three paragraphs)
with a Fixes tag...

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] MAINTAINERS: rectify entry for MICROCHIP USB251XB DRIVER
  2022-11-15 10:35 ` Krzysztof Kozlowski
@ 2022-11-15 10:52   ` Marek Vasut
  2022-11-15 10:54     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2022-11-15 10:52 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Lukas Bulwahn, Greg Kroah-Hartman, linux-usb
  Cc: Richard Leitner, kernel-janitors, linux-kernel

On 11/15/22 11:35, Krzysztof Kozlowski wrote:
> On 15/11/2022 11:31, Lukas Bulwahn wrote:
>> Commit fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema")
>> converts usb251xb.txt to usb251xb.yaml, but misses to adjust its reference
>> in MAINTAINERS.
>>
>> Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
>> broken reference.
>>
>> Repair this file reference in MICROCHIP USB251XB DRIVER.
>>
> You know this could be just one sentence (instead of three paragraphs)
> with a Fixes tag...

On the other hand, the content is educational, e.g. about the usage of 
get_maintainer.pl script .

Acked-by: Marek Vasut <marex@denx.de>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] MAINTAINERS: rectify entry for MICROCHIP USB251XB DRIVER
  2022-11-15 10:52   ` Marek Vasut
@ 2022-11-15 10:54     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-15 10:54 UTC (permalink / raw)
  To: Marek Vasut, Lukas Bulwahn, Greg Kroah-Hartman, linux-usb
  Cc: Richard Leitner, kernel-janitors, linux-kernel

On 15/11/2022 11:52, Marek Vasut wrote:
> On 11/15/22 11:35, Krzysztof Kozlowski wrote:
>> On 15/11/2022 11:31, Lukas Bulwahn wrote:
>>> Commit fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema")
>>> converts usb251xb.txt to usb251xb.yaml, but misses to adjust its reference
>>> in MAINTAINERS.
>>>
>>> Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
>>> broken reference.
>>>
>>> Repair this file reference in MICROCHIP USB251XB DRIVER.
>>>
>> You know this could be just one sentence (instead of three paragraphs)
>> with a Fixes tag...
> 
> On the other hand, the content is educational, e.g. about the usage of 
> get_maintainer.pl script .

Education is good, but I don't see a point to grow commit log with this.
The warning would be useful, but the command? Just store it in
Documentation if the intention is to educate.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-11-15 10:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-15 10:31 [PATCH] MAINTAINERS: rectify entry for MICROCHIP USB251XB DRIVER Lukas Bulwahn
2022-11-15 10:35 ` Krzysztof Kozlowski
2022-11-15 10:52   ` Marek Vasut
2022-11-15 10:54     ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).