From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12C9EC2BA1A for ; Sat, 4 Apr 2020 10:06:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DAD87206F5 for ; Sat, 4 Apr 2020 10:06:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="aTi0ATN9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726230AbgDDKGC (ORCPT ); Sat, 4 Apr 2020 06:06:02 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:36293 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726148AbgDDKGB (ORCPT ); Sat, 4 Apr 2020 06:06:01 -0400 Received: by mail-lj1-f196.google.com with SMTP id b1so9540197ljp.3 for ; Sat, 04 Apr 2020 03:05:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=f5WeYVcExZ58viobGo5xENBYY/7iA5WtiHNaBP74Ohk=; b=aTi0ATN9MaY24407laRnBef6LfGPpOgdRBwSwCQz2c3RW4Gj/WkUSmsjFupt1+Si1I /jw0cOt3bzoZ1L8XI8Cd7xl4uND//yB9GJHWzUv8WZWdrs2vMEb5P/6AngfEuXPZiSGf XPfLEX+uHTRcYFmBj3aEbcKNRHtdDgUwBBnViuTIu3RWq8uVF0MXaSq7dRYUFOEfUxag Me75vpJfK3iUGksokG2xHslbFjKJVBBYOFEjoY7PYPAXlsjqaldQ3YKyfSNa7FMzpHkn t+K46duTvK6NW20LFcqGjElqmIe9KQb5vJm4zg6VH9x14j7uPUY0uawotq+psxvUvGUB UXxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=f5WeYVcExZ58viobGo5xENBYY/7iA5WtiHNaBP74Ohk=; b=cTAklK7fGlFZk+JDZWllqlrrArA4MOA/9gQKF8I2mRXWLrBxkM3/nvfjPr8C9EueIa d8Qal6B0ThiYPOEzr0isu5MGmoeACurfYUdUxHE7ccyje9DXQAjyU4lxwfTJkLNcycEq p0K0BpyQrIwrBopOSj2R/jnLZpNR+HvRPSr3yeINymrZoXoBnym2JVTHOJDSnQd6mWjc 3ELbv52d4QEfJ/UOCcw45FUmHWoOajyJFvBAxcqULD3RMf79EJd7vCb1lsSf/qG5ES8K lHzM4dY62K+DTFc3L5HuJZFll4Z9xiX0VHP/E+nJ5CGo9r7QL6Zk4esCuSI8K1/ef6Qr fRLg== X-Gm-Message-State: AGi0PuanIZpRDgCqPxDZxKAwMpW8l7z4eN5MFSwuFGpBELvQx0tjpmpN CXUfki3yRbPPIcdgSEUyTWBqSg== X-Google-Smtp-Source: APiQypJgK3TXAPv85OfJ7vCTcz4u4tUzYYbvpr+INBxhiypWT+murLDDhRYYaeJT38bk35encw/Ldg== X-Received: by 2002:a2e:818e:: with SMTP id e14mr7232769ljg.225.1585994757852; Sat, 04 Apr 2020 03:05:57 -0700 (PDT) Received: from ?IPv6:2a00:1fa0:6f0:5f98:6c2c:3527:3946:ae? ([2a00:1fa0:6f0:5f98:6c2c:3527:3946:ae]) by smtp.gmail.com with ESMTPSA id p21sm6378055ljg.5.2020.04.04.03.05.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Apr 2020 03:05:57 -0700 (PDT) Subject: Re: [PATCH 2/6] i915/gvt/kvm: a NULL ->mm does not mean a thread is a kthread To: Christoph Hellwig , Linus Torvalds , Andrew Morton Cc: Al Viro , Felix Kuehling , Alex Deucher , Zhenyu Wang , Zhi Wang , Felipe Balbi , "Michael S. Tsirkin" , Jason Wang , Jens Axboe , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-usb@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-mm@kvack.org References: <20200404094101.672954-1-hch@lst.de> <20200404094101.672954-3-hch@lst.de> From: Sergei Shtylyov Message-ID: <0fb3cce8-fa3d-5c97-1eba-0f359797eea2@cogentembedded.com> Date: Sat, 4 Apr 2020 13:05:52 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200404094101.672954-3-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hello! On 04.04.2020 12:40, Christoph Hellwig wrote: > Use the proper API instead. > > Fixes: f440c8a572d7 ("drm/i915/gvt/kvmgt: read/write GPA via KVM API") > Signed-off-by: Christoph Hellwig > --- > drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c > index 074c4efb58eb..5848400620b4 100644 > --- a/drivers/gpu/drm/i915/gvt/kvmgt.c > +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c > @@ -2037,7 +2037,7 @@ static int kvmgt_rw_gpa(unsigned long handle, unsigned long gpa, > struct kvmgt_guest_info *info; > struct kvm *kvm; > int idx, ret; > - bool kthread = current->mm == NULL; > + bool kthread = (current->flags & PF_KTHREAD); Don't need the parens. [...] MBR, Sergei