From: Selvarasu G <selvarasu.g@samsung.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "mathias.nyman@intel.com" <mathias.nyman@intel.com>,
"WeitaoWang-oc@zhaoxin.com" <WeitaoWang-oc@zhaoxin.com>,
"Thinh.Nguyen@synopsys.com" <Thinh.Nguyen@synopsys.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
JaeHun Jung <jh0801.jung@samsung.com>,
JUNG Daehwan <dh10.jung@samsung.com>,
NAUSHAD KOLLIKKARA <naushad@samsung.com>,
Akash M <akash.m5@samsung.com>,
Hyunsoon Kim <h10.kim@samsung.com>,
OH Eomji <eomji.oh@samsung.com>,
ALIM AKHTAR <alim.akhtar@samsung.com>,
Thiagu Ramalingam <thiagu.r@samsung.com>,
Muhammed Ali K P <muhammed.ali@samsung.com>,
Pritam Manohar Sutar <pritam.sutar@samsung.com>,
CPGS <cpgs@samsung.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] usb: xhci: Initialize unassigned variables to fix possible errors
Date: Tue, 11 Feb 2025 17:37:13 +0900 [thread overview]
Message-ID: <1296674576.21739268902551.JavaMail.epsvc@epcpadp1new> (raw)
In-Reply-To: CGME20250210131144epcas5p4a0599050f5973b495db0371021c21e27@epcms5p7
On 2/11/2025 11:28 AM, Greg KH wrote:
> On Mon, Feb 10, 2025 at 06:41:23PM +0530, Selvarasu Ganesan wrote:
>> Fix the following smatch errors:
>>
>> drivers/usb/host/xhci-mem.c:2060 xhci_add_in_port() error: unassigned variable 'tmp_minor_revision'
>> drivers/usb/host/xhci-hub.c:71 xhci_create_usb3x_bos_desc() error: unassigned variable 'bcdUSB'
>>
>> Fixes: d9b0328d0b8b ("xhci: Show ZHAOXIN xHCI root hub speed correctly")
>> Fixes: eb02aaf21f29 ("usb: xhci: Rewrite xhci_create_usb3_bos_desc()")
> This should be two different changes, right?
>
> Please break it up and send as a patch series.
>
> thanks,
>
> greg k-h
Hi Greg,
Thanks for your comments. Sure i will send as a patch series.
Thanks,
Selva
next parent reply other threads:[~2025-02-11 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250210131144epcas5p4a0599050f5973b495db0371021c21e27@epcms5p7>
2025-02-11 8:37 ` Selvarasu G [this message]
[not found] <CGME20250210131144epcas5p4a0599050f5973b495db0371021c21e27@epcas5p4.samsung.com>
2025-02-10 13:11 ` [PATCH] usb: xhci: Initialize unassigned variables to fix possible errors Selvarasu Ganesan
2025-02-11 5:58 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296674576.21739268902551.JavaMail.epsvc@epcpadp1new \
--to=selvarasu.g@samsung.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=WeitaoWang-oc@zhaoxin.com \
--cc=akash.m5@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=cpgs@samsung.com \
--cc=dh10.jung@samsung.com \
--cc=eomji.oh@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=h10.kim@samsung.com \
--cc=jh0801.jung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=muhammed.ali@samsung.com \
--cc=naushad@samsung.com \
--cc=pritam.sutar@samsung.com \
--cc=stable@vger.kernel.org \
--cc=thiagu.r@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox