Re: [PATCH 3/4] usb: xhci-pci: use the interrupter entry as MSI dev_id

["Neronin, Niklas" <niklas.neronin@linux.intel.com>]

On 30/04/2026 9.42, raoxu wrote:
> From: Xu Rao <raoxu@uniontech.com>
> 
> After routing xhci_msi_irq() through xhci_interrupter, PCI
> MSI setup still registers the primary vector with usb_hcd as
> the request_irq() dev_id.
> 
> Use &xhci->interrupters[0] instead, pass the same dev_id to
> free_irq(), and release the IRQ before xhci_stop() tears
> down the interrupter array.
> 
...
> 
> @@ -225,10 +225,10 @@ static void xhci_pci_stop(struct usb_hcd *hcd)
>  {
>  	struct xhci_hcd *xhci = hcd_to_xhci(hcd);
> 
> -	xhci_stop(hcd);
> -
>  	if (usb_hcd_is_primary_hcd(hcd))
>  		xhci_cleanup_msix(xhci);
> +
> +	xhci_stop(hcd);

Won't this now free the MSI-X interrupt before it has been disabled?

Best Regards,
Niklas

>  }
> 
>  /* called after powerup, by probe or system-pm "wakeup" */
> --
> 2.50.1
>