Re: [PATCH 2/2] USB: xhci: use urb hcpriv mempool for private data

["David Wang" <00107082@163.com>]

At 2025-05-13 16:21:06, "Oliver Neukum" <oneukum@suse.com> wrote:
>Hi,
>
>On 13.05.25 07:55, David Wang wrote:
>> xhci keeps alloc/free private data for each enqueue/dequeue cycles,
>> when using a USB webcam, the memory allocation frequency could reach
>> about 1k/s.
>> 
>> URB objects have longer lifecycle than private data, hand over ownership
>> of private data to urb can save lots of memory allocations over time.
>
>I am afraid I need to make a comment about a principal issue.
>
>This patch set overlooks a fundamental issue. You cannot guarantee
>that an URB is reused by the same HC. For example you cannot rule
>out that the next time your URB is resubmitted, it will land with
>XHCI again.
>
>That means you cannot touch just how one HCD handles private data.
>Or you need to record which HC the URB was last used for.

No, I don't think which HC the URB was last used for concerns here.
A URB cannot be used by two HC at the same time, as long as this hold, I don't see reason
 worrying about who use this private data before.

This patch for xhci dose not assume which HC use the private data mempool  previously, nor
should other HCs.

Or, do I misunderstand your comments?

David

>
>	Regards
>		Oliver