From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: steve.glendinning@shawell.net, UNGLinuxDriver@microchip.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com,
Andre Werner <andre.werner@systec-electronic.com>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
daniel.krueger@systec-electronic.com,
Andre Werner <andre.werner@systec-electronic.com>
Subject: Re: [PATCH net-next] net: smsc95xx: add support for SYS TEC USB-SPEmodule1
Date: Thu, 15 Feb 2024 08:50:00 +0100 [thread overview]
Message-ID: <13454529.uLZWGnKmhe@steina-w> (raw)
In-Reply-To: <20240214132507.28072-1-andre.werner@systec-electronic.com>
Hi Andre,
Am Mittwoch, 14. Februar 2024, 14:25:07 CET schrieb Andre Werner:
> This patch adds support for the SYS TEC USB-SPEmodule1 10Base-T1L
> ethernet device to the existing smsc95xx driver by adding the new
> USB VID/PID pair.
>
> Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
> ---
> drivers/net/usb/smsc95xx.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
> index a530f20ee257..bb4e62a93d96 100644
> --- a/drivers/net/usb/smsc95xx.c
> +++ b/drivers/net/usb/smsc95xx.c
> @@ -2109,6 +2109,11 @@ static const struct usb_device_id products[] = {
> USB_DEVICE(0x184F, 0x0051),
> .driver_info = (unsigned long)&smsc95xx_info,
> },
> + {
> + /* SYSTEC USB-SPEmodule1 10BASE-T1L Ethernet Device */
> + USB_DEVICE(0x0878, 0x1400),
> + .driver_info = (unsigned long)&smsc95xx_info,
> + },
IMHO entries should be sorted by USB Vendor ID. So this goes before
Microchip's EVB-LAN8670-USB.
Best regards,
Alexander
> { }, /* END */
> };
> MODULE_DEVICE_TABLE(usb, products);
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
prev parent reply other threads:[~2024-02-15 7:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 13:25 [PATCH net-next] net: smsc95xx: add support for SYS TEC USB-SPEmodule1 Andre Werner
2024-02-15 7:50 ` Alexander Stein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13454529.uLZWGnKmhe@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andre.werner@systec-electronic.com \
--cc=daniel.krueger@systec-electronic.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox