From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Prashanth K <quic_prashk@quicinc.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [v2] usb: common: usb-conn-gpio: Prevent bailing out if initial role is none
Date: Tue, 1 Aug 2023 12:50:08 +0200 [thread overview]
Message-ID: <144125c0-4524-5617-dbb0-bf2575f56d4a@collabora.com> (raw)
In-Reply-To: <1690869695-32018-1-git-send-email-quic_prashk@quicinc.com>
Il 01/08/23 08:01, Prashanth K ha scritto:
> Currently if we bootup a device without cable connected, then
> usb-conn-gpio won't call set_role() since last_role is same as
> current role. This happens because during probe last_role gets
> initialised to zero.
>
> To avoid this, add a new flag initial_detection in the struct
> usb_conn_info, which prevents from bailing out during initial
> detection.
>
> Fixes: 4602f3bff266 ("usb: common: add USB GPIO based connection detection driver")
> Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
MediaTek platforms:
Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
prev parent reply other threads:[~2023-08-01 10:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 6:01 [v2] usb: common: usb-conn-gpio: Prevent bailing out if initial role is none Prashanth K
2023-08-01 6:14 ` Greg Kroah-Hartman
2023-08-01 10:50 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=144125c0-4524-5617-dbb0-bf2575f56d4a@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=quic_prashk@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox