From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] usb: typec: tcpm: qcom: use connector to specify VBUS regulator.
Date: Tue, 19 May 2026 12:41:59 +0100 [thread overview]
Message-ID: <1485d619-35da-48e1-a108-60de1bd8b19b@linaro.org> (raw)
In-Reply-To: <20260519-fix-tcpm-vbus-v1-0-14754695282d@oss.qualcomm.com>
On 19/05/2026 11:48, Dmitry Baryshkov wrote:
> The Qualcomm PMIC Type-C devices historically provided their own way of
> specifying the VBUS regulator, via the device's vdd-vbus-supply node.
> This is not ideal as the VBUS is supplied to the connector and not to
> the Type-C block in the PMIC. In theory hardware can use different
> regulators for VBUS, so specifying it in the PMIC DTSI is not correct.
> Deprecate this property in favour of the standard way of specifying it
> (via the connector's vbus-supply property).
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> Dmitry Baryshkov (6):
> dt-bindings: usb: qcom,pmic-typec: deprecate device-specific VBUS
> usb: typec: tcpm: qcom: prefer VBUS supply from the connector node
> arm64: dts: qcom: pm4125: move vdd-vbus-supply to connector nodes
> arm64: dts: qcom: pm7250b: move vdd-vbus-supply to connector nodes
> arm64: dts: qcom: pm8150b: move vdd-vbus-supply to connector nodes
> arm64: dts: qcom: pmi632: move vdd-vbus-supply to connector nodes
>
> Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml | 4 ++--
> arch/arm64/boot/dts/qcom/pm4125.dtsi | 1 -
> arch/arm64/boot/dts/qcom/pm7250b.dtsi | 1 -
> arch/arm64/boot/dts/qcom/pm8150b.dtsi | 1 -
> arch/arm64/boot/dts/qcom/pmi632.dtsi | 1 -
> arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 2 ++
> arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 2 ++
> arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 2 ++
> arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 2 ++
> arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 2 ++
> arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts | 2 ++
> arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 2 ++
> arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi | 2 ++
> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 12 +++++++++++-
> 14 files changed, 29 insertions(+), 7 deletions(-)
> ---
> base-commit: 80dd246accce631c328ea43294e53b2b2dd2aa32
> change-id: 20260519-fix-tcpm-vbus-aabde21f339d
>
> Best regards,
> --
> With best wishes
> Dmitry
>
It should be possible to use vbus from any source - and that vbus is
indeed port not controller specific.
For the series
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
bod
prev parent reply other threads:[~2026-05-19 11:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 10:48 [PATCH 0/6] usb: typec: tcpm: qcom: use connector to specify VBUS regulator Dmitry Baryshkov
2026-05-19 10:48 ` [PATCH 1/6] dt-bindings: usb: qcom,pmic-typec: deprecate device-specific VBUS Dmitry Baryshkov
2026-05-19 11:26 ` Konrad Dybcio
2026-05-19 11:37 ` Bryan O'Donoghue
2026-05-19 10:48 ` [PATCH 2/6] usb: typec: tcpm: qcom: prefer VBUS supply from the connector node Dmitry Baryshkov
2026-05-19 11:25 ` Konrad Dybcio
2026-05-19 14:05 ` Heikki Krogerus
2026-05-19 10:48 ` [PATCH 3/6] arm64: dts: qcom: pm4125: move vdd-vbus-supply to connector nodes Dmitry Baryshkov
2026-05-19 11:26 ` Konrad Dybcio
2026-05-19 10:48 ` [PATCH 4/6] arm64: dts: qcom: pm7250b: " Dmitry Baryshkov
2026-05-19 11:27 ` Konrad Dybcio
2026-05-19 10:48 ` [PATCH 5/6] arm64: dts: qcom: pm8150b: " Dmitry Baryshkov
2026-05-19 11:27 ` Konrad Dybcio
2026-05-19 10:48 ` [PATCH 6/6] arm64: dts: qcom: pmi632: " Dmitry Baryshkov
2026-05-19 11:27 ` Konrad Dybcio
2026-05-19 11:41 ` Bryan O'Donoghue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485d619-35da-48e1-a108-60de1bd8b19b@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox