From: zhengyongjun <zhengyongjun3@huawei.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andrey Konovalov <andreyknvl@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Masahiro Yamada <masahiroy@kernel.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Ahmed S. Darwish" <a.darwish@linutronix.de>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Sasha Levin <sashal@kernel.org>,
Allen Pais <allen.lkml@gmail.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
pmail_hulkci <hulkci@huawei.com>
Subject: 答复: [PATCH -next] usb: remove unused including <linux/version.h>
Date: Fri, 26 Mar 2021 06:43:08 +0000 [thread overview]
Message-ID: <14b5f1093ccb42798653360d10757e93@huawei.com> (raw)
In-Reply-To: <YF2BX7Ps9DcQe5tu@kroah.com>
Sorry, I will check all my patch later before I send to maintainer and I will stop this patch series.
-----邮件原件-----
发件人: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org]
发送时间: 2021年3月26日 14:38
收件人: zhengyongjun <zhengyongjun3@huawei.com>
抄送: Andrey Konovalov <andreyknvl@google.com>; Dmitry Vyukov <dvyukov@google.com>; Masahiro Yamada <masahiroy@kernel.org>; Sebastian Andrzej Siewior <bigeasy@linutronix.de>; Ahmed S. Darwish <a.darwish@linutronix.de>; Gustavo A. R. Silva <gustavoars@kernel.org>; Sasha Levin <sashal@kernel.org>; Allen Pais <allen.lkml@gmail.com>; linux-usb@vger.kernel.org; kernel-janitors@vger.kernel.org; pmail_hulkci <hulkci@huawei.com>
主题: Re: [PATCH -next] usb: remove unused including <linux/version.h>
On Fri, Mar 26, 2021 at 02:13:26PM +0800, Zheng Yongjun wrote:
> Remove including <linux/version.h> that don't need it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/usb/core/hcd.c | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index
> 3f0381344221..53bc93d6eb0c 100644
> --- a/drivers/usb/core/hcd.c
> +++ b/drivers/usb/core/hcd.c
> @@ -11,7 +11,6 @@
> #include <linux/bcd.h>
> #include <linux/module.h>
> -#include <linux/version.h>
> #include <linux/kernel.h>
> #include <linux/sched/task_stack.h>
> #include <linux/slab.h>
>
Your tool is VERY broken. Please stop sending patches that you obviously do not even test before submitting:
https://lore.kernel.org/r/1614733752-56541-1-git-send-email-tiantao6@hisilicon.com
It's a sure way to make maintainers very grumpy.
greg k-h
prev parent reply other threads:[~2021-03-26 6:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 6:13 [PATCH -next] usb: remove unused including <linux/version.h> Zheng Yongjun
2021-03-26 6:38 ` Greg Kroah-Hartman
2021-03-26 6:43 ` zhengyongjun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14b5f1093ccb42798653360d10757e93@huawei.com \
--to=zhengyongjun3@huawei.com \
--cc=a.darwish@linutronix.de \
--cc=allen.lkml@gmail.com \
--cc=andreyknvl@google.com \
--cc=bigeasy@linutronix.de \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).